956995 - Remove prtypes.h inclusions from intl/

Status: RESOLVED FIXED

(Core :: Internationalization, defect, P5)

Description

[Masatoshi Kimura [:emk]]

This is no longer needed.

Comment 1

[(no longer active)]

Kill them with fire!

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: patch

I couldn't remove the inclusion from ubase.h because it was used from C code and MSVC 2010 didn't support bool in C-mode :(

Try run: https://tbpl.mozilla.org/?tree=Try&rev=8838d125235f

Comment 3

[(no longer active)]

(In reply to comment #2)
> Created attachment 8357268 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=8357268&action=edit
> patch
> 
> I couldn't remove the inclusion from ubase.h because it was used from C code
> and MSVC 2010 didn't support bool in C-mode :(

Can you use int instead of PRBool in that code?

Comment 4

[Masatoshi Kimura [:emk]]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #3)
> Can you use int instead of PRBool in that code?

Hm. Simon, what do you think?

Comment 5

[Simon Montagu :smontagu]

(In reply to Masatoshi Kimura [:emk] from comment #4)
> (In reply to :Ehsan Akhgari (needinfo? me!) from comment #3)
> > Can you use int instead of PRBool in that code?
> 
> Hm. Simon, what do you think?

I'm OK with that.

Comment 6

[Masatoshi Kimura [:emk]]

Attachment: Stop using prtypes in unicpriv.h

I also removed useless macros while I'm here.
Try running: https://tbpl.mozilla.org/?tree=Try&rev=dbaf71e1b7db

Comment 7

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d0b216a52799
https://hg.mozilla.org/integration/mozilla-inbound/rev/f64886a9237a

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d0b216a52799
https://hg.mozilla.org/mozilla-central/rev/f64886a9237a