Closed Bug 956995 Opened 7 years ago Closed 7 years ago

Remove prtypes.h inclusions from intl/

Categories

(Core :: Internationalization, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: emk, Assigned: emk)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [qa-])

Attachments

(2 files)

This is no longer needed.
Kill them with fire!
Severity: normal → trivial
Priority: -- → P5
Attached patch patchSplinter Review
I couldn't remove the inclusion from ubase.h because it was used from C code and MSVC 2010 didn't support bool in C-mode :(

Try run: https://tbpl.mozilla.org/?tree=Try&rev=8838d125235f
Attachment #8357268 - Flags: review?(smontagu)
(In reply to comment #2)
> Created attachment 8357268 [details] [diff] [review]
>   --> https://bugzilla.mozilla.org/attachment.cgi?id=8357268&action=edit
> patch
> 
> I couldn't remove the inclusion from ubase.h because it was used from C code
> and MSVC 2010 didn't support bool in C-mode :(

Can you use int instead of PRBool in that code?
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #3)
> Can you use int instead of PRBool in that code?

Hm. Simon, what do you think?
Flags: needinfo?(smontagu)
Attachment #8357268 - Flags: review?(smontagu) → review+
(In reply to Masatoshi Kimura [:emk] from comment #4)
> (In reply to :Ehsan Akhgari (needinfo? me!) from comment #3)
> > Can you use int instead of PRBool in that code?
> 
> Hm. Simon, what do you think?

I'm OK with that.
Flags: needinfo?(smontagu)
I also removed useless macros while I'm here.
Try running: https://tbpl.mozilla.org/?tree=Try&rev=dbaf71e1b7db
Attachment #8357947 - Flags: review?(smontagu)
Attachment #8357947 - Flags: review?(smontagu) → review+
https://hg.mozilla.org/mozilla-central/rev/d0b216a52799
https://hg.mozilla.org/mozilla-central/rev/f64886a9237a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.