Closed
Bug 956995
Opened 10 years ago
Closed 10 years ago
Remove prtypes.h inclusions from intl/
Categories
(Core :: Internationalization, defect, P5)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: emk, Assigned: emk)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [qa-])
Attachments
(2 files)
931 bytes,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
92.32 KB,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
This is no longer needed.
Assignee | ||
Updated•10 years ago
|
Comment 1•10 years ago
|
||
Kill them with fire!
Updated•10 years ago
|
Severity: normal → trivial
Priority: -- → P5
Assignee | ||
Comment 2•10 years ago
|
||
I couldn't remove the inclusion from ubase.h because it was used from C code and MSVC 2010 didn't support bool in C-mode :( Try run: https://tbpl.mozilla.org/?tree=Try&rev=8838d125235f
Attachment #8357268 -
Flags: review?(smontagu)
Comment 3•10 years ago
|
||
(In reply to comment #2) > Created attachment 8357268 [details] [diff] [review] > --> https://bugzilla.mozilla.org/attachment.cgi?id=8357268&action=edit > patch > > I couldn't remove the inclusion from ubase.h because it was used from C code > and MSVC 2010 didn't support bool in C-mode :( Can you use int instead of PRBool in that code?
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #3) > Can you use int instead of PRBool in that code? Hm. Simon, what do you think?
Flags: needinfo?(smontagu)
Updated•10 years ago
|
Attachment #8357268 -
Flags: review?(smontagu) → review+
Comment 5•10 years ago
|
||
(In reply to Masatoshi Kimura [:emk] from comment #4) > (In reply to :Ehsan Akhgari (needinfo? me!) from comment #3) > > Can you use int instead of PRBool in that code? > > Hm. Simon, what do you think? I'm OK with that.
Flags: needinfo?(smontagu)
Assignee | ||
Comment 6•10 years ago
|
||
I also removed useless macros while I'm here. Try running: https://tbpl.mozilla.org/?tree=Try&rev=dbaf71e1b7db
Attachment #8357947 -
Flags: review?(smontagu)
Updated•10 years ago
|
Attachment #8357947 -
Flags: review?(smontagu) → review+
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0b216a52799 https://hg.mozilla.org/integration/mozilla-inbound/rev/f64886a9237a
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Flags: in-testsuite-
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d0b216a52799 https://hg.mozilla.org/mozilla-central/rev/f64886a9237a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•