956999 - Please unhide the linux64-valgrind job on TBPL

Status: RESOLVED FIXED

(Tree Management Graveyard :: Visibility Requests, defect)

Description

[Nicholas Nethercote [inactive]]

As soon as bug 956951 (which will deploy relevant TBPL changes) is completed, the linux64-valgrind job will meet the requirements at:
https://wiki.mozilla.org/Sheriffing/Job_Visibility_Policy

Please may it be unhidden!

Details...

> 1) Has an active owner

Yes, me.

> 2) Breakage is expected to be followed by tree closure or backout
> 3) Runs on mozilla-central and all trees that merge into it
> 4) Scheduled on every push
> 5) Easily run on try server

Yes, yes, yes, yes. 

> 6) Outputs failures in a TBPL-starrable format

Yes. When Valgrind finds errors, the "ERROR SUMMARY" line gets highlighted. The
specific errors don't get shown in the summary, so you have to open the log
file to see them.  But the ASan builds are the same, and edmorley indicated
this was acceptable in bug 952605.

(This is just waiting on bug 956951 to put the relevant TBPL changes into
production.)

> 7) Low intermittent failure rate
> 8) Must avoid patterns known to cause non deterministic failures

Yes and yes.

> 9) Supports the disabling of individual tests

N/A. However, individual error reports can be suppressed if necessary, which is
similar.

> 10) Has sufficient documentation

Yes: https://developer.mozilla.org/en-US/docs/Mozilla/QA/Automated_testing has
an entry that points to
https://developer.mozilla.org/en-US/docs/Valgrind_test_job.

> 11) Easy for a dev to run locally

|mach valgrind-test|

> 12) Crashes should produce valid crash stacks

The crash reporter is enabled. I don't think anything else needs doing?

Comment 1

[Ed Morley [:emorley]]

Looks good to me - thank you for driving this!

Valgrind unhidden on {mozilla-central, mozilla-inbound, fx-team, b2g-inbound, try} :-)