957120 - Download notification date is 2027

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Download Manager, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Attachment: Date Download Notification

Tested with:
Build: Firefox for Android 27 Beta 4
Device: LG Nexus 4
OS: Android 4.3

Steps to reproduce:
1. Go to http://goo.gl/SRCLe to download the file
2. Go to android notification bar

Expected result:
- The download notification date should be correct

Actual result:
- The download notification date is 10/12/2027

Please see the attached screenshot

Comment 1

[Aaron Train [:aaronmt]]

This is the same as bug 933775, but it was uplifted to mozilla-beta in early December.

Is the date correct on the device? Reproducible on other devices?

Comment 2

[Teodora Vermesan (:TeoVermesan)]

Yes, the date is 07/01/2014.
Reproducible on Samsung Galaxy Tab (Android 4.0.4) and Google Nexus 7 (Android 4.4)

Comment 3

[Aaron Train [:aaronmt]]

Federico/gcp is there a code disparity on mozilla-beta and other branches for this?

Comment 4

[Gian-Carlo Pascutto [:gcp]]

The patch looks OK to me in mozilla-aurora and mozilla-beta, though the file itself is fairly different.

This bug has dates in the future. The bug you refer to had dates in the past (really, unix time 0). So it's not exactly the same, though the cause probably ain't too far away.

Comment 5

[Federico Paolinelli]

I guess the bug is here http://mxr.mozilla.org/mozilla-beta/source/mobile/android/chrome/content/downloads.js#99

The NotificationBuilder expects the when parameter as the number of millisecs since the epoch, whereas aDownload.startTime is the same time expressed in microsecs, so its the number it expects * 1000.

I can provide a patch tomorrow, since I don't currently have a beta checkout and I would like to test the patch before submitting.

Comment 6

[Federico Paolinelli]

Attachment: bug-957120-fix

This is the patch. I guess the bug affects only beta, since from aurora the when parameter is calculated in a different way.

Comment 7

[Gian-Carlo Pascutto [:gcp]]

Frederico, can you request beta approval for your patch?

Comment 8

[Federico Paolinelli]

Sure, I just need to know how to do it :)

Comment 9

[Gian-Carlo Pascutto [:gcp]]

Click on your patch->details->approval-mozilla-beta?  It will give you a template to fill in.

Comment 10

[Federico Paolinelli]

Comment on attachment 8356853 [details] [diff] [review]
bug-957120-fix

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 933775 
User impact if declined: Wrong download date time in download notification
Testing completed (on m-c, etc.): Tested on checked out beta
Risk to taking this patch (and alternatives if risky): Low, only changed the value to be used as notification time
String or IDL/UUID changes made by this patch: None

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4a876256830e

Comment 12

[Flaviu Cos]

Verified as fixed in  build: 27 beta 6;
Device: Google Nexus 7 (Android 4.4.2);