Closed
Bug 957220
Opened 10 years ago
Closed 10 years ago
Enable code to build from m-c's config/rules.mk copies
Categories
(MailNews Core :: Build Config, defect)
MailNews Core
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 29.0
People
(Reporter: jcranmer, Assigned: jcranmer)
References
Details
Attachments
(4 files)
2.50 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
602 bytes,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
2.32 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
916 bytes,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
Coincidentally, all of the changes are specific either to Windows code or pymake code.
Assignee | ||
Comment 1•10 years ago
|
||
It's used in only one place, so might as well not bother trying to port all the logic to m-c for cc-rework. Fortunately, the png part of it is small, so there is no need to muck about with virtualenv \o/
Attachment #8356673 -
Flags: review?(mbanner)
Assignee | ||
Comment 2•10 years ago
|
||
This was originally part of my MAPI testing patch, but since that fails on try but not locally for non-obvious reasons, I've pulled the ccrework-blocking portion out of it.
Attachment #8356680 -
Flags: review?(mbanner)
Assignee | ||
Comment 3•10 years ago
|
||
Apparently mozilla-central is using pymake builtins to do preprocessing, but comm-central is using shell calls, and pymake screams if you don't quote {.
Attachment #8356681 -
Flags: review?(mbanner)
Assignee | ||
Comment 4•10 years ago
|
||
And with this, Alder is now green for Windows.
Attachment #8357194 -
Flags: review?(mbanner)
(In reply to Joshua Cranmer [:jcranmer] from comment #1) > Created attachment 8356673 [details] [diff] [review] > Part 1: Move png2ico out of config/config.mk > > It's used in only one place, so might as well not bother trying to port all > the logic to m-c for cc-rework. Fortunately, the png part of it is small, so > there is no need to muck about with virtualenv \o/ There is also a reference to png2ico in http://mxr.mozilla.org/comm-central/source/build/check-sync-exceptions#4
Comment 6•10 years ago
|
||
Comment on attachment 8356673 [details] [diff] [review] Part 1: Move png2ico out of config/config.mk r=Standard8 if you update the check-sync-dirs instance as well.
Attachment #8356673 -
Flags: review?(mbanner) → review+
Updated•10 years ago
|
Attachment #8356680 -
Flags: review?(mbanner) → review+
Updated•10 years ago
|
Attachment #8356681 -
Flags: review?(mbanner) → review+
Updated•10 years ago
|
Attachment #8357194 -
Flags: review?(mbanner) → review+
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/287a93b9779a https://hg.mozilla.org/comm-central/rev/c9169bcd6f4f https://hg.mozilla.org/comm-central/rev/af840d94732d https://hg.mozilla.org/comm-central/rev/3b5aff8c2921
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 29.0
You need to log in
before you can comment on or make changes to this bug.
Description
•