957281 - Help button should be positioned at the lower end of the preferences window

Status: RESOLVED FIXED

(Toolkit :: Preferences, defect)

Description

[Stefan [:stefanh]]

We should position the help button at the lower end of the prefwindow when 'browser.preferences.instantApply' is set to true.

HIG:
"In dialogs (including preferences windows) and drawers, the Help button can be located in either the lower-left or lower-right corner. In a dialog that includes OK and Cancel buttons (or other buttons used to dismiss the dialog), the Help button should be in the lower-left corner, vertically aligned with the buttons. In a dialog that does not include OK and Cancel buttons, such as a preferences window, the Help button should be in the lower-right corner. For example, the Mail Fonts & Colors preference displays a Help button in the lower-right corner."

Comment 1

[Stefan [:stefanh]]

Attachment: Move the button

Comment 2

[Asaf Romano (gone)]

I'll try to get this done this week.

Comment 3

[Asaf Romano (gone)]

Comment on attachment 8356743 [details] [diff] [review]
Move the button

I prefer hiding the spacer over moving nodes around.

document.getAnonymousElementByAttribute(this "anonid", "spacer").hidden = true

should work.

Comment 4

[Stefan [:stefanh]]

(In reply to Mano from comment #3)
> document.getAnonymousElementByAttribute(this "anonid", "spacer").hidden =
> true
> 
> should work.

Yeah, but 'pack="end"' only applies to windows (see the ifdef starting at 576). I can of course set it when I hide the spacer - what do you think?

Comment 5

[Asaf Romano (gone)]

Yes, that's better. When we introduce platform difference in xbl widgets like this, it's almost always better to have the difference in the form of an attribute rather than in the tree structure.

Comment 6

[Stefan [:stefanh]]

Attachment: 957281.2.diff

I had a discussion with Neil about this and it's of course so that the pack attribute will only affect the layout of the buttons when the spacer is hidden. pack="end" was included in the ifdef in bug 309140, and the patch there also unhided the spacers.

So, I decided to revert the pack attribute changes made for 8 1/2 years ago :-)

Comment 7

[Stefan [:stefanh]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d276863a7e3

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6d276863a7e3