957525 - [Flatfish][Video] H264 MP4/3GPP Thumbnail color inverted

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: ColorInvertedFlatfish.png

GECKO_REV=3a5c8b3e9cb12b868616997fd89cfdeec628292e
GAIA_REV=45860a3651eb9f860c59f2273028f921f2ef338b
GECKO_BRANCH=mozillaorg/master
GAIA_BRANCH=mozillaorg/master
BUILD_TAG=jenkins-B2G.master.flatfish-109
BuildID=20140108064521

1. Push some H264 MP4/3GPP files onto Flatfish
2. Open "Video".
3. Check thumbnail on the left. See ColorInvertedFlatfish.png

Comment 1

[Eric Chang [:ericcc] [:echang]]

Attachment: NormalThumbnailBURI.png

Comment 2

[Francis Lee [:frlee]]

hi John,

are you able to check this issue?

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

I need device to do the test.

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: the canvas element for creating image

This bug is caused by the drawImage API of canvas element with video element.

The right panel of the attachment shows the canvas for creating the thumbnail. In this attachment, we can find the canvas draws the image with wrong color to the canvas. It looks like the color space of video and canvas are different and we use wrong settings to draw the video onto canvas.

This may need to check with hardware codec and canvas element.

BTW, this issue only happened to MP4 with h.264 codec. It works correctly with webm, 3gpp, and ogg files.

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

I have no idea about this bug. Please help to find graphics team and codec team to check this. BTW, I had showed this issue to jerry. It seems not a general r-g swapping bug but only related to specific codec.

Comment 6

[Jerry Shih[:jerry] (UTC+8) (inactive)]

We might have r-b channel swap problem when we enable hardware composer, but we don't use hardware composer to render in this case. I think that might be other problem.

Comment 7

[Sotaro Ikeda [:sotaro]]

Video's color format is converted to RGB565 at GrallocImage::GetAsSurface().
The function seems not working correctly because of hw dependent reason.

http://mxr.mozilla.org/mozilla-central/source/gfx/layers/GrallocImages.cpp

Comment 8

[Vincent Liu[:vliu]]

(In reply to Jerry Shih[:jerry] from comment #6)
> We might have r-b channel swap problem when we enable hardware composer, but
> we don't use hardware composer to render in this case. I think that might be
> other problem.

I can still see this issue even disabling hw composer in Settings app.

Comment 9

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Hi John,

Can you just provide a template app and just draw the thumbnail?
I will try to trace the path of converting to RGB56 path.

Comment 10

[John Hu [:johnhu][:johu][:醬糊小弟]]

It's possible. Please give me times to do that.

Comment 11

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: test app

Jerry,

This is the test app which is based on template app, you know it.

There are two buttons in it, play video and draw image. When play video is tapped, it loads video into Video element. When draw image is tapped, it uses offscreen video element to draw its screenshot on the canvas and attached to screen.

Comment 12

[John Hu [:johnhu][:johu][:醬糊小弟]]

Jerry is checking on this, no need to ask francis

Comment 13

[John Hu [:johnhu][:johu][:醬糊小弟]]

One more thing:

The difference is the globe icon at the left-bottom corner which should be "blue" but drawn as "orange".

(In reply to John Hu [:johnhu] from comment #11)
> Created attachment 8358251 [details]
> test app
> 
> Jerry,
> 
> This is the test app which is based on template app, you know it.
> 
> There are two buttons in it, play video and draw image. When play video is
> tapped, it loads video into Video element. When draw image is tapped, it
> uses offscreen video element to draw its screenshot on the canvas and
> attached to screen.

Comment 14

[Richard Pappalardo [:rpapa][:rpappalardo]]

Attachment: 2014-04-26 13.49.52.jpg

Preview for normal gallery photos is fine (as you can see).  Preview for videos in gallery appears with a purple hue

Comment 15

[BMO Automation]

Firefox OS is not being worked on