957584 - Incorrect CSS rules in the Settings/Downloads panel

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Fabien Cazenave [:kaze]]

Following bug 935088, these CSS warnings are reported by adb:

E/GeckoConsole( 2855): [JavaScript Warning: "Error in parsing value for 'overflow'.  Declaration dropped." {file: "app://settings.gaiamobile.org/style/downloads.css" line: 34 column: 12 source: "  overflow: none;"}]
E/GeckoConsole( 2855): [JavaScript Warning: "Unknown property '-moz-boz-sizing'.  Declaration dropped." {file: "app://settings.gaiamobile.org/style/downloads.css" line: 126 column: 17 source: "  -moz-boz-sizing: border-box;"}]
E/GeckoConsole( 2855): [JavaScript Warning: "Unknown property '-moz-boz-sizing'.  Declaration dropped." {file: "app://settings.gaiamobile.org/style/downloads.css" line: 132 column: 17 source: "  -moz-boz-sizing: border-box;"}]

Comment 1

[Fabien Cazenave [:kaze]]

Attachment: patch

Borja, feel free to steal this bug if you want. :-)

Comment 2

[Borja Salguero [:borjasalguero]]

Kaze! If you want I could take this and try to fix the '!important' in the CSS modifying the JS code. Wdyt? Thanks!

Comment 3

[Fabien Cazenave [:kaze]]

Hey Borja, that’d be nice. :-)

Comment 4

[Borja Salguero [:borjasalguero]]

Comment on attachment 8357114 [details] [review]
patch

Cleaning the flags. I'll try to fix as well the hide class using 'hidden' attribute. Thanks!

Comment 5

[Borja Salguero [:borjasalguero]]

Attachment: Pull request

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8359214 [details] [review]
Pull request

Incredible job, so clean now!

Thanks, tried on the phone and works perfectly, just left one ni on github.

Comment 7

[Borja Salguero [:borjasalguero]]

Comment addressed! Kaze, r?

Comment 10

[Fabien Cazenave [:kaze]]

Comment on attachment 8359214 [details] [review]
Pull request

R=me with nits addressed, see my comments on github regarding the use of boolean attributes.

This is a very nice cleanup, thanks Borja!

Comment 11

[Borja Salguero [:borjasalguero]]

https://github.com/mozilla-b2g/gaia/commit/1d2654e55bafa2c48838eb35cff8ec28ba32391c
https://github.com/borjasalguero/gaia/commit/96d2fb464261463f9cbc56dd5fcbc77c52a67e99
R+. Merged.