957847 - VTTCue crash [@ mozilla::dom::TextTrack::AddCue]

Status: VERIFIED FIXED

(Core :: Audio/Video, defect)

Description

[Jesse Ruderman]

Attachment: testcase (crashes Firefox when loaded)

Comment 1

[Jesse Ruderman]

Attachment: stack

Nightly: bp-6366885c-59a0-480e-8b0b-6f08e2140108

Comment 2

[Rick Eyre (:reyre)]

Attachment: v1: Fix VTTCue crash at TextTrackCue::AddCue r=rillian

Problem was that TextTracks don't always have an HTMLMediaElement, like in this case.

Comment 3

[Ralph Giles (:rillian)]

Comment on attachment 8360468 [details] [diff] [review]
v1: Fix VTTCue crash at TextTrackCue::AddCue r=rillian

Review of attachment 8360468 [details] [diff] [review]:
-----------------------------------------------------------------

If the track is later parented to the media element, does AddCue get called then?

Comment 4

[Rick Eyre (:reyre)]

(In reply to Ralph Giles (:rillian) from comment #3)
> Comment on attachment 8360468 [details] [diff] [review]
Thanks for review Ralph.

> v1: Fix VTTCue crash at TextTrackCue::AddCue r=rillian
> 
> Review of attachment 8360468 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> If the track is later parented to the media element, does AddCue get called
> then?

I don't think so. I'm not sure we would need to do it. It depends on if the algorithm that loads the text track calls for it to be added to one of the other cue or text track lists. That's something we've only partially tackled with adding the pending text track list and new cue list. I'll open a bug to follow up looking more deeply into that though.

Comment 5

[Rick Eyre (:reyre)]

Try push: https://tbpl.mozilla.org/?tree=Try&rev=33583dfc8eae

Comment 6

[Rick Eyre (:reyre)]

Follow up bug 960184.

Comment 7

[Rick Eyre (:reyre)]

Looks green.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/47534210aede

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/47534210aede

Comment 10

[Paul Silaghi, QA [:pauly]]

Reproduced in Nightly 2014-01-08.
Verified fixed 29.0a1 (2014-01-17), win 7 x64