957906 - [fugu][buri][settings] cannot backward from keyboard settings

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Peipei Cheng (needinfo if you need my action)]

This is a regression from v1.2.

Test Environment:
--------------------------
Buri V1.3
Gaia      522779225e86b7a4d1bf759036678dc321a1486e                         
Gecko     http://hg.mozilla.org/releases/mozilla-aurora/rev/2287f2839256   
BuildID   20140108004001                                                   
Version   28.0a2                                                           
ro.build.version.incremental=eng.archermind.20131114.105818                
ro.build.date=Thu Nov 14 10:58:33 CST 2013 

Reproduce Steps:
--------------------------
1. Launch Settings
2. go to Keyboards -> Built-in keyboards, keyboard settings page appears
3. Tap on the backward button
   --> A black screen appears. User cannot do any operation.

Btw, I also tested with follow build. The behavior is the page switches between Built-in keyboards and keyboard settings.

Gaia ff5f06dd321f7d2bf4a5b311ded2c56e865d4f83
Gecko http://hg.mozilla.org/releases/mozilla-aurora/rev/71ad7ff30010
BuildID 20140107004001
Version 28.0a2
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013

Comment 2

[Peter Bylenga [:PBylenga]]

The regression window is 1/7 to 1/8. Appears related to the 1.3 uplift of bug 947033.

Last build that the issue does not reproduce:

Environmental Variables
Device: Buri v1.3 Mozilla RIL
Build ID: 20140107004001
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/71ad7ff30010
Gaia: ff5f06dd321f7d2bf4a5b311ded2c56e865d4f83
Platform Version: 28.0a2
Firmware Version: 20131115


First build that the issue reproduces:

Environmental Variables
Device: Buri v1.3 Mozilla RIL
Build ID: 20140108004001
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/2287f2839256
Gaia: 522779225e86b7a4d1bf759036678dc321a1486e
Platform Version: 28.0a2
Firmware Version: 20131115

Comment 3

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

After removing |window.close()|, black screen still appears but user can tap home button to back to homescreen.

It might be a windows_manager issue or gecko issue. 
https://github.com/mozilla-b2g/gaia/blob/v1.3/apps/keyboard/js/settings/settings.js#L19

please refer to bug 957987#c1

Comment 4

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Hi all,
   I found the root cause.
   Since |settings.webActivityHandler| will fallback into |activityRequest.postError| and then |WindowManager| will set ActivityCaller(keybaord APP) to frontend, but there is something wrong in |WindowManager|, so we will get black screen in this scenario.

   Even |WindowManager| resolved this issue, the flow still not correct as I mentioned above |WindowManager| will bring keyboard into frontend, so I add additional flag |postback: false| to resolve this bug. 

   And also I will file another bug for |WindowManager|.

   https://github.com/mozilla-b2g/gaia/blob/v1.3/apps/settings/js/settings.js#L590
   https://github.com/mozilla-b2g/gaia/blob/v1.3/apps/system/js/window.js#L241

Comment 5

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Attachment: pull request: https://github.com/mozilla-b2g/gaia/pull/15239

Hi Arthur and Rudy,
   Please help to review my patch, it is for v1.3 only.

   Thanks.

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8359073 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/15239

r+ for the keyboard app part and I left some comments on the settings app part.
Please help address that.

Thank you.

Comment 7

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

As comment 4, here is the follow up bug  bug 959056.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Triage: +'ing, functional regression.

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8359073 [details] [review]
pull request: https://github.com/mozilla-b2g/gaia/pull/15239

r=me. Thanks!

Comment 11

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

travis- passed: 
https://travis-ci.org/mozilla-b2g/gaia/builds/16852563

land in v1.3:
https://github.com/mpizza/gaia/commit/e4a00bee5ce687c37992c64ca6e87f0800667ec3

Comment 12

[William Hsu [:whsu]]

Thanks for the help!
Verified it.

* Verified Build: (Device -> Buri)
 - Gaia      47049555282a9a01fb60d1e1421b57e2810c96f5
 - Gecko     http://hg.mozilla.org/releases/mozilla-aurora/rev/6f7dfe36ab6c
 - BuildID   20140121004137
 - Version   28.0a2

* Result:
 - Cannot reproduce it.

Comment 14

[Joell Lapitan]

bug still exist on v1.4

Comment 15

[Tim Guan-tin Chien [:timdream] (please needinfo)]

The patch didn't land on 1.4.

This issue was a 1.3-specific window management issue.

Comment 16

[William Hsu [:whsu]]

(In reply to Joell Lapitan from comment #14)
> bug still exist on v1.4

Hi, Joell,

Do you mean you still can reproduce it?
If so, could you please provide the git commit number and build ID?

I cannot reproduce this bug on following V1.4 build.
Thanks.

* Build information:
 - Gaia      3534b4880653f24529c973ec2f09ef51a3d6392f
 - Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/12171cfe5ded
 - BuildID   20140414160201
 - Version   30.0a2