957971 - [Download Manager] A notification "download failed" is displayed after deleted a stopped or failed download

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[rafael.marquez]

*Procedure
1. Download a  file
2. Open the download list during the download process
3. Stop the download proccess
4. Open edit mode in downloadd list
5. Select a delete the stopped download

*Expected Result
The stopped download is deleted successfully

*Actual Result
A notification "download failed" is displayed after deleted a stopped or failed download

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: 15250.html

When you go to Github, the tests seem to have been changed completely but I just refactored all tests in a suite and added a new one to test this patch

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8359150 [details]
15250.html

Looking good to me, tried on the phone and working :)

Thanks!

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 8359150 [details]
15250.html

I find it strange to add the notification and then remove it.

Keeping my review? flag until this is cleared.

Comment 4

[Cristian Rodriguez (:crdlc)]

Hi Julien, you can review it again because I addressed all comments. I explained in Github why I did that :). But I removed that strange code in my last implementation. Thx!

Comment 5

[Julien Wajsberg [:julienw]]

Comment on attachment 8359150 [details]
15250.html

r=me

I left a last comment but this is not blocking IMO so change it if you like :)

Thanks!

Comment 6

[Julien Wajsberg [:julienw]]

Francisco, maybe you'd want to have a look on the last version too ?

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Hi,

just saw the changes asked by Julien, pretty nice all of them, not modifying the underline concept of the PR, tried on the phone again and working, so I'm more than happy.


Thanks guys!

Comment 8

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/crdlc/gaia/commit/3a5f2efab600a40456deef28ea540b9937af535a

Thanks a lot guys for your help!