958147 - Choose one of run-if or skip-if and get rid of the other

Status: NEW

(Testing :: Mochitest, defect)

Description

[(no longer active)]

AFAICT |skip-if COND| and |run-if !COND| are equivalent.  There's no reason why we should have two ways of doing this, we should just pick one and remove the other.

Comment 1

[(not currently active) Ted Mielczarek]

I'm not clear on why we have both, we should just pick one. Existing usage heavily favors skip-if:
http://mxr.mozilla.org/mozilla-central/search?string=skip-if&find=\.ini%24&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central (501 matches)
http://mxr.mozilla.org/mozilla-central/search?string=run-if (78 matches)

Comment 2

[(no longer active)]

Then skip-if it is!  I'm not sure any of them have any inherent advantages over the other one.

Comment 3

[(not currently active) Ted Mielczarek]

I don't think so, it just means you get to stick an extra ! in there for some conditions.

Comment 4

[(no longer active)]

Where does the code responsible for parsing this stuff live?

Comment 5

[(not currently active) Ted Mielczarek]

http://mxr.mozilla.org/mozilla-central/source/testing/mozbase/manifestdestiny/manifestparser/manifestparser.py#1034

Comment 6

[Jaspreet Singh]

I want to work on this bug. Please assign this to me.

Comment 7

[Jaspreet Singh]

Attachment: choose.patch

I'll make the required changes in http://mxr.mozilla.org/mozilla-central/source/testing/mozbase/manifestdestiny/manifestparser/manifestparser.py#1034 once this runs clean

Comment 8

[(not currently active) Ted Mielczarek]

Comment on attachment 8378103 [details] [diff] [review]
choose.patch

Review of attachment 8378103 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch! This looks great, I just have one thing I'd like changed. Also, we should definitely run this by the try server.

::: testing/mozbase/manifestdestiny/tests/filter-example.ini
@@ +1,4 @@
>  # illustrate test filters based on various categories
>  
>  [windowstest]
> +skip-if = os != 'win'

Heh, this is a unit test for manifestdestiny. How about you leave this out until we remove run-if support from the manifestparser?

Comment 9

[Jaspreet Singh]

Attachment: choose2.patch

updated with the requested change

Comment 10

[(not currently active) Ted Mielczarek]

Comment on attachment 8378373 [details] [diff] [review]
choose2.patch

Pushed to try:
https://tbpl.mozilla.org/?tree=Try&rev=88942102201f

Comment 11

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

ted, did we land this?

Comment 12

[(not currently active) Ted Mielczarek]

I don't think it landed, no.

Comment 13

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

Ted, can you verify this patch solves this bug and get it landed?

Comment 14

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

repinging :ted on here, we are 10 weeks out with crickets.

Comment 15

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

Attachment: s/run-if/skip-if/ updated original patch for bitrot (2.0)

Comment 16

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

pushed to try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7f50b156cbb

If this goes well, we can land this and assert if we have remaining run-if statements.

Comment 17

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

Attachment: s/run-if/skip-if/ updated original patch for bitrot (2.1) (checked in)

Comment 18

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

run with fixed up issue on xperf:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5db3c46d8156

run with everything else (broken xperf):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7586bc328d56

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fbfffe99ab60

Comment 20

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fbfffe99ab60

Comment 21

[(not currently active) Ted Mielczarek]

Joel: thanks for getting this landed!  	
Jaspreet: thanks for the patch!

Comment 22

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

hmm, there are a few more instances now:
https://dxr.mozilla.org/mozilla-central/search?q=run-if&case=true&redirect=true

maybe we could do another round here, get it in and remove the run-if tag from manifestparser?

Comment 23

[(not currently active) Ted Mielczarek]

You can just have blanket-r=me to fix those. If you want to get a patch up to remove run-if from manifestparser I can review that in advance and you can land them together.

Comment 24

[Lalit M [:darklord]]

@Ted Mielczarek I want to work on this bug.Please assign it to me.

Comment 25

[(not currently active) Ted Mielczarek]

Lalit: Hi there. I'm sorry, but I think someone else is already working on the remaining parts of this bug.

Comment 26

[Anish]

yah thanks Ted. Lalit : sorry man ! I am already working on it

Comment 27

[Anish]

Attachment: first.patch

I have made a patch to prohibit the further use of run-if´s and also replaced the already existing run-if´s with skip-if

Comment 28

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

Comment on attachment 8558010 [details] [diff] [review]
first.patch

Review of attachment 8558010 [details] [diff] [review]:
-----------------------------------------------------------------

on the items I mention I am not sure, no need to change things, the rest should be adjusted and I will run it on try server.

::: browser/components/uitour/test/browser.ini
@@ +21,5 @@
>  skip-if = e10s # Bug 941428 - UITour.jsm not e10s friendly.
>  [browser_UITour_loop.js]
>  skip-if = e10s # Bug 941428 - UITour.jsm not e10s friendly.
>  [browser_UITour_modalDialog.js]
> +skip-if = os!= "mac" && e10s # modal dialog disabling only working on OS X.Bug 941428 - UITour.jsm not e10s friendly

1) keep the spacing nicely: os != "mac"
2) || e10s

::: dom/ipc/tests/mochitest.ini
@@ +13,2 @@
>  [test_CrashService_crash.html]
> +skip-if = !(crashreporter && !e10s && (toolkit == 'gtk2' || toolkit == 'gtk3' || toolkit == 'cocoa' || toolkit == 'windows') && (buildapp != 'b2g' || toolkit == 'gonk'))

I am not sure if this will work.  In fact I am not sure what the original statement means.

(toolkit == 'gtk2' || toolkit == 'gtk3' || toolkit == 'cocoa' || toolkit == 'windows') - I believe this is linux/windows/mac
(buildapp != 'b2g' || toolkit == 'gonk') - I believe this is desktop b2g

so really we want to skip-if: !crashreporter && e10s && (buildapp != 'b2g' || android)

I am not sure.

::: image/test/mochitest/mochitest.ini
@@ +92,5 @@
>  skip-if = toolkit == "gonk" #Bug 997034 - canvas.toDataURL() often causes lost connection to device.
>  [test_error_events.html]
>  [test_short_gif_header.html]
>  [test_image_buffer_limit.html]
> +Firefox OS currently.

we have a random line here.  Hmm, we should leave this in since it had metadata about the test, but lets put it as:
#skip-if = toolkit != "gonk" #<original comment>

::: memory/replace/dmd/test/xpcshell.ini
@@ +28,5 @@
>  
>  # Bug 1077230 explains why this test is disabled on Mac 10.6.
>  [test_dmd.js]
>  dmd = true
> +skip-if = !(os == 'linux' || os == 'mac' && os_version != '10.6' || os == 'win')

I am not sure if this is correct.

::: testing/mozbase/docs/manifestparser.rst
@@ +282,5 @@
>    test is disabled
>  - tags : keys and values to filter on (e.g. `os='linux'`)
>  
>  `active_tests` looks for tests with `skip-if`
> +.  If the condition is or is not fulfilled,

this doesn't look correct, could you pull the period to the previous like and format it similarly.

@@ +287,4 @@
>  respectively, the test is marked as disabled.  For instance, if you
>  pass `**dict(os='linux')` as `**tags`, if a test contains a line
>  `skip-if = os == 'linux'` this test will be disabled, or
> +.  It

same here.

::: testing/mozbase/manifestparser/manifestparser/manifestparser.py
@@ +705,5 @@
>  
>      def filter(self, values, tests):
>          """
>          filter on a specific list tag, e.g.:
> +        skip-if = os != win linux

just remove this line

Comment 29

[Anish]

Attachment: first.patch

Improved first patch based on comments

Comment 30

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

Comment on attachment 8558061 [details] [diff] [review]
first.patch

Review of attachment 8558061 [details] [diff] [review]:
-----------------------------------------------------------------

4 things below, please do fix these up and I think we will be ready to go.

::: image/test/mochitest/mochitest.ini
@@ +93,4 @@
>  [test_error_events.html]
>  [test_short_gif_header.html]
>  [test_image_buffer_limit.html]
> +Firefox OS currently.

please fix this line, this won't build or run at all, lets convert it to a skip-if and comment it out with the same comment.

::: memory/replace/dmd/test/xpcshell.ini
@@ +28,5 @@
>  
>  # Bug 1077230 explains why this test is disabled on Mac 10.6.
>  [test_dmd.js]
>  dmd = true
> +skip-if = os != 'linux' && (os == 'mac' && os_version == '10.6') && os != 'win')

this has a trailing ')', that won't work.

Also I think this should be:
skip-if = !(linux && win) || mac=10.6

::: testing/mozbase/docs/manifestparser.rst
@@ +281,5 @@
>    test's metadata will be present and will be set to the reason that a
>    test is disabled
>  - tags : keys and values to filter on (e.g. `os='linux'`)
>  
> +`active_tests` looks for tests with `skip-if`.If the condition is or is not fulfilled,respectively, the test is marked as disabled.  For instance, if you pass `**dict(os='linux')` as `**tags`, if a test contains a line`skip-if = os == 'linux'` this test will be disabled, or

two spaces after a .

'skip-if'.  If the...

@@ +282,5 @@
>    test is disabled
>  - tags : keys and values to filter on (e.g. `os='linux'`)
>  
> +`active_tests` looks for tests with `skip-if`.If the condition is or is not fulfilled,respectively, the test is marked as disabled.  For instance, if you pass `**dict(os='linux')` as `**tags`, if a test contains a line`skip-if = os == 'linux'` this test will be disabled, or
> +.It is up to the harness to pass in tags appropriate to its usage.

this is messed up, it should be more like:
if a test contains a line `skip-if = os = 'linux'` this test will be disabled.  It is up ....

Comment 31

[Anish]

Attachment: first.patch

Altered based on the comments

Comment 32

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

Comment on attachment 8558100 [details] [diff] [review]
first.patch

Review of attachment 8558100 [details] [diff] [review]:
-----------------------------------------------------------------

ah, 2 small issues.

When you get these fixed, do a build and verify it completes.  Then do a simple sanity test run with mach.

::: image/test/mochitest/mochitest.ini
@@ +88,5 @@
>  [test_bug89419-2.html]
>  skip-if = (toolkit == 'android' && processor == 'x86') #x86 only
>  [test_animation_operators.html]
>  [test_drawDiscardedImage.html]
> +skip-if = toolkit != "gonk" #Image buffer limit is only set for Firefox OS currently.

the comment here is missing- the skip-if is correct.

@@ +93,4 @@
>  [test_error_events.html]
>  [test_short_gif_header.html]
>  [test_image_buffer_limit.html]
>  #run-if = toolkit == "gonk" #Image buffer limit is only set for Firefox OS currently.

leave this commented out and change it to skip-if = toolkit != "gonk"

::: memory/replace/dmd/test/xpcshell.ini
@@ +28,5 @@
>  
>  # Bug 1077230 explains why this test is disabled on Mac 10.6.
>  [test_dmd.js]
>  dmd = true
> +skip-if = !(linux && win) || mac=10.6

this won't work, we need proper syntax here:
skip-if !(os=='linux' || os=='win') || (os=='mac' && os_version=='10.6')

Comment 33

[Anish]

Attachment: first.patch

Comment 34

[Anish]

Attachment: first.patch

Comment 35

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

Comment on attachment 8558616 [details] [diff] [review]
first.patch

Review of attachment 8558616 [details] [diff] [review]:
-----------------------------------------------------------------

great, let me test this on try server

Comment 36

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

https://tbpl.mozilla.org/?tree=Try&rev=1f6d9c979d85

Comment 37

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

on try server there are two error I see of concern:
* b2g desktop 'a' job: https://treeherder.mozilla.org/logviewer.html#?job_id=4687164&repo=try
** found a run-if in '/builds/slave/test/gaia/tests/python/gaia-ui-tests/gaiatest/tests/accessibility/manifest.ini'
** this is in a different repo and located here: https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/accessibility/ftu/manifest.ini

* mulet linux 64 '1' job: https://treeherder.mozilla.org/logviewer.html#?job_id=4687166&repo=try
** 03:21:18 INFO - 1010 INFO TEST-UNEXPECTED-FAIL | dom/base/test/test_hasFeature.html | Endpoint Navigator.getMobileIdAssertion resolved with the correct value. If this is failing because you're changing how an API is exposed, you must contact the Marketplace team to let them know about the change. - got true, strictly expected undefined
** this manifest: https://dxr.mozilla.org/mozilla-central/source/dom/base/test/mochitest.ini?from=dom/base/test/mochitest.ini&case=true#1
** two run-if conditions switched to skip-if- not sure if this is related to an existing failure or the changes.
** we don't seem to run this test on any of the branches (inbound, central, b2g-inbound), so I have no idea if this passes normally

The first issue is something we will need to fix prior to landing this, :davehunt, what is the process for changing a gaia-ui-test?  Do we submit a pull request, file a bug, etc?

Comment 38

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Joel Maher (:jmaher) from comment #37)
> The first issue is something we will need to fix prior to landing this,
> :davehunt, what is the process for changing a gaia-ui-test?  Do we submit a
> pull request, file a bug, etc?

Please provide a pull request and attach to a bug. This bug will be fine, you can ask :Bebe for review.

Comment 39

[Anish]

https://github.com/mozilla-b2g/gaia/pull/28462 

the pull request for change of run-if to skip-if in https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/accessibility/ftu/manifest.ini

Comment 40

[Anish]

Attachment: Pull Request for the change in run-if in the files in gaia (checked in)

Comment 41

[Martijn Wargers (dead)]

Comment on attachment 8569362 [details] [review]
Pull Request for the change in run-if in the files in gaia (checked in)

Looks good, the test run also was green on treeherder try.

Comment 42

[Martijn Wargers (dead)]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #41)
> Comment on attachment 8569362 [details] [review]
> Pull Request for the change in run-if in the files in gaia
> 
> Looks good, the test run also was green on treeherder try.

Merged in https://github.com/mozilla-b2g/gaia/commit/2e92c9bf543f5401c65402a775c9adc388f45673

Comment 43

[Anish]

Attachment: firstpatch.diff

Comment 44

[Anish]

Attachment: run.patch (checked in)

Comment 45

[Martijn Wargers (dead)]

(In reply to Anish from comment #44)
> Created attachment 8570895 [details] [diff] [review]
> run.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ace722d291a

Comment 46

[Martijn Wargers (dead)]

I think the last patch ( https://bugzilla.mozilla.org/attachment.cgi?id=8570895 ) can be checked in, right Joel? The treeherder try run seems fine to me and you already reviewed this patch.

Comment 47

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

yes, this is ready for checkin!

Comment 48

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/451dda813637

Comment 49

[Andrew Halberstadt [:ahal]]

Once this lands, don't forget to remove the run_if filter:
https://dxr.mozilla.org/mozilla-central/source/testing/mozbase/manifestparser/manifestparser/filters.py#34

Comment 50

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/451dda813637

Comment 51

[Martijn Wargers (dead)]

(In reply to Andrew Halberstadt [:ahal] from comment #49)
> Once this lands, don't forget to remove the run_if filter:
> https://dxr.mozilla.org/mozilla-central/source/testing/mozbase/
> manifestparser/manifestparser/filters.py#34

Anish, could you perhaps do that? After that is done, I think this bug can be closed.

Comment 52

[Anish]

yah ! sure mwargers I will edit it and make a patch soon !

Comment 53

[Anish]

Attachment: final.patch

Time to close it :)

Comment 54

[Andrew Halberstadt [:ahal]]

Comment on attachment 8572550 [details] [diff] [review]
final.patch

Review of attachment 8572550 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch, though there's some stuff you're missing. You'll also need to:
* remove it from DEFAULT_FILTERS in that file
* update the docstring for DEFAULT_FILTERS
* remove the associated test: https://dxr.mozilla.org/mozilla-central/source/testing/mozbase/manifestparser/tests/test_filters.py#105

Comment 55

[Anish]

Attachment: final.patch

Comment 56

[Andrew Halberstadt [:ahal]]

Comment on attachment 8572719 [details] [diff] [review]
final.patch

Review of attachment 8572719 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Please address the two comments below and upload a new patch that includes the original change as well.

::: testing/mozbase/manifestparser/tests/test_filters.py
@@ -91,4 @@
>          { "name": "test3", "fail-if": "foo == 'bar'" },
>          { "name": "test4", "disabled": "some reason" },
>          { "name": "test5", "subsuite": "baz" },
>          { "name": "test6", "subsuite": "baz,foo == 'bar'" })

Please rename the test numbers

@@ -103,5 @@
>          self.assertNotIn(self.tests[1], tests)
>  
> -    def test_run_if(self):
> -        tests = deepcopy(self.tests)
> -        tests = list(run_if(tests, {}))

You'll also need to remove the import.

Comment 57

[Anish]

Attachment: final.patch

Comment 58

[Andrew Halberstadt [:ahal]]

Comment on attachment 8572755 [details] [diff] [review]
final.patch

Review of attachment 8572755 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, but this patch doesn't have the original change that removes the run_if function, could you combine this with your first patch so that they can be landed together?

Comment 59

[Anish]

Attachment: final.patch

Comment 60

[Anish]

Attachment: final.patch

Comment 61

[Andrew Halberstadt [:ahal]]

Comment on attachment 8572817 [details] [diff] [review]
final.patch

Review of attachment 8572817 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for your contribution!

Comment 62

[Anish]

Attachment: final.patch

Comment 63

[Andrew Halberstadt [:ahal]]

Comment on attachment 8572824 [details] [diff] [review]
final.patch

Review of attachment 8572824 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for updating the patch info, for future no need to ask for a new review, you can just set it to a + yourself :)

Comment 64

[Andrew Halberstadt [:ahal]]

Attachment: Remove run_if filter

This just modifies the commit message.

Comment 65

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b3fe7a6a4939

Comment 66

[Carsten Book [:Tomcat]]

sorry had to back this out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=7245538&repo=mozilla-inbound

Comment 67

[Anish]

Attachment: final.patch

Comment 68

[Anish]

Attachment: final.patch

Comment 69

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/99c2fcc61cc2

Comment 70

[Ryan VanderMeulen [:RyanVM]]

Backed out for test failures on B2G Desktop and Mulet.
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad7dc4416bc3

https://treeherder.mozilla.org/logviewer.html#?job_id=7249310&repo=mozilla-inbound

Comment 71

[Nicholas Nethercote [inactive]]

> ::: memory/replace/dmd/test/xpcshell.ini
> @@ +28,5 @@
> >  
> >  # Bug 1077230 explains why this test is disabled on Mac 10.6.
> >  [test_dmd.js]
> >  dmd = true
> > +skip-if = !(linux && win) || mac=10.6
> 
> this won't work, we need proper syntax here:
> skip-if !(os=='linux' || os=='win') || (os=='mac' && os_version=='10.6')

That's an incorrect rewrite :(  See bug 1172568.

Comment 72

[Stanley Mwangi [:smwangi]]

Attachment: final.patch after bitrot

Comment 73

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

thanks for updating the patch Stanley!  I have pushed to try and in 4 hours or so (i.e. tomorrow) we will see the results:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a799a9bf7cca

The results will determine if we need to fix other areas that have changed since the patch was originally created.

Comment 74

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

Comment on attachment 8649456 [details] [diff] [review]
final.patch after bitrot

Review of attachment 8649456 [details] [diff] [review]:
-----------------------------------------------------------------

cancelling the review, on Try there are a lot of consistent failures, I believe most of these are due to manifests which have run-if conditions.  Those will need to be converted to skip-if either as part of this patch or in a secondary patch which we land first.

Comment 75

[Jaewoongyu]

Hello
My name is Jaewoong Yu and I am a student at Coventry University.  
I was wondering if I could ask you something
Is it possible to get permission to fix the bugs?
Because this is my coursework for my subject which is 389COM open-source-development.

Comment 76

[Nicholas Nethercote [inactive]]

Jaewoong Yu: I have assigned the bug to you. I think this is fine since it has been two years since Anish tried to fix it. I suggest using the existing patches as a starting point, but you will probably need to do additional work to account for the changes since then.

If you haven't seen it already, 
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction has lots of helpful information for new contributors. Good luck!

Comment 77

[Dailin Zhang]

Hello
I am Zhangdailin from Coventry University
Could you allow me to fix the bugs for my coursework?
I am doing Open-source-development.
Thank you

Comment 78

[Jaewoongyu]

(In reply to Jaewoongyu from comment #75)
> Hello
> My name is Jaewoong Yu and I am a student at Coventry University.  
> I was wondering if I could ask you something
> Is it possible to get permission to fix the bugs?
> Because this is my coursework for my subject which is 389COM
> open-source-development.

Hello
I actually couldn't find the bugs. Could you please give me the link to go there?
Thank you

Comment 79

[Nicholas Nethercote [inactive]]

Jaewoong Yu: this page is the bug report for one bug, which has bug number 958147. There are some old patches attached in the "Attachments" section near the top of the page. One or more of these might be a good starting place, but they are likely to be out-of-date and needing changes. I recommend you read through all the comments to get an understanding of the problem to be solved, and prior attempts to solve them.

Comment 80

[Dailin Zhang]

(In reply to Nicholas Nethercote [:njn] from comment #79)
> Jaewoong Yu: this page is the bug report for one bug, which has bug number
> 958147. There are some old patches attached in the "Attachments" section
> near the top of the page. One or more of these might be a good starting
> place, but they are likely to be out-of-date and needing changes. I
> recommend you read through all the comments to get an understanding of the
> problem to be solved, and prior attempts to solve them.

could you assigned me a bug????

Comment 81

[Nicholas Nethercote [inactive]]

Dailin Zhang: I assigned this bug to Jaewoong Yu because they asked first.

To find another suitable bug, I suggest you read https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction, particularly the "Step 2 - Find something to work on" section.

Comment 82

[Jaewoongyu]

I have read all comments but I am still not 100% sure which file of bugs I should fix.

dom/canvas/test/webgl-conf/generate-wrappers-and-manifest.py can I fix this bug ? I have just found it from the link on the comments.

Comment 83

[Jaewoongyu]

Could you please reply to me ??

Thank you

Comment 84

[simtmbd]

can i work on this issue

Comment 85

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.