958848 - bookmarks: Deleting of couple of separators delete whole folder

Status: NEW

(Firefox :: Bookmarks & History, defect, P3)

Description

[Alexey Korop]

Steps to reproduce:
1. Create bookmarks folder named, f.e. "Temp".
2. Create in this folder some entries;
3. Create inside this folder couple of separators (two separators beside);
4. Click "Bookmarks" menu and move mouse pointer to these separators (normal items must not be hilighted);
5. Right click and select "Delete"

Expected result: one of separators is deleted.
Actual result: whole (sub)folder "Temp" is deleted (nonrecoverable!).

Additional info: this problem present in Seamonkey 2.23 also.

Comment 1

[sjw]

I cannot reproduce using current Nightly on Windows.

Comment 2

[Alexey Korop]

Yes, you're right. Now I test some versions with te results below:

bug present:
  firefox 26 Linux
  firefox nightly Linux (firefox-27.0.en-US.debug-linux-i686.tar.bz2)
  seamonkey 2.23 Linux
  seamonkey 2.23 Windows
  seamonkey nightly Linux (seamonkey-2.26a1.en-US.linux-i686.tar.bz2)
  seamonkey nightly Windows (seamonkey-2.26a1.en-US.win32.installer.exe)

works fine:
  firefox 26 windows
  firefox nightly windows (firefox-27.0.en-US.debug-win32.installer.exe)

Comment 3

[Nadia Rodriguez]

(In reply to Alexey Korop from comment #0)
> Steps to reproduce:
> 1. Create bookmarks folder named, f.e. "Temp".
> 2. Create in this folder some entries;
> 3. Create inside this folder couple of separators (two separators beside);
> 4. Click "Bookmarks" menu and move mouse pointer to these separators (normal
> items must not be hilighted);
> 5. Right click and select "Delete"
> 
> Expected result: one of separators is deleted.
> Actual result: whole (sub)folder "Temp" is deleted (nonrecoverable!).
> 
> Additional info: this problem present in Seamonkey 2.23 also.

I have confirmed this bug by testing it in the firefox nightly Linux 30.0a1 (2014-02-05) with the steps provided.

Comment 4

[Marco Bonardo [:mak]]

if you restart the browser, is the folder gone or does it come back?

Comment 5

[Alexey Korop]

(In reply to Marco Bonardo [:mak] from comment #4)
> if you restart the browser, is the folder gone or does it come back?
No. (Now I test this in Seamonkey 2.24 32bit Linux).

Comment 6

[Marco Bonardo [:mak]]

"no" means it's lost?

Comment 7

[Alexey Korop]

Deleted folder is not come back.

Comment 9

[Alice0775 White]

Now, it is able to reproduce on Australis Bookmarks Widget very easily

Comment 10

[Marco Bonardo [:mak]]

We should disable the context menu when the selectedNode is the popup resultNode... while it makes sense to have a context menu on the bare toolbar, doesn't make sense on a popup. The problem is that this may make deleting separators a targeting game users may not want to play (not that it's very easy as of now).

Comment 11

[Marco Bonardo [:mak]]

Is this still reproducible?

Comment 12

[Alexey Korop]

Bug is present - in seamonley 2.32.1 linux64, Win32.
Bug is NOT present - in firefox 36.0.4 linux64

About needinfo: I call seamonkey linux64 from terminal and view no messages during buggy deletion.

Comment 13

[Alice0775 White]

I can still reproduce the problem in Australis Bookmarks Widget on Nightly40.0a1.

 https://hg.mozilla.org/mozilla-central/rev/26d6392b5403
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.0 ID:20150330114816

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

In the process of migrating remaining bugs to the new severity system, the severity for this bug cannot be automatically determined. Please retriage this bug using the new severity system.

Comment 17

[Mark Banner (:standard8)]

Comment 10 is a possible way of fixing this.