Closed Bug 958908 Opened 10 years ago Closed 10 years ago

Remove usage of deprecated/observer-service

Categories

(Add-on SDK Graveyard :: General, defect)

Product:
Add-on SDK Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: evold, Assigned: evold)

References

Details

Attachments

(1 file)

Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1343
46 bytes, text/x-github-pull-request
jsantell
: review+
Details | Review 
      No description provided.
Assignee: nobody → evold
Comment on attachment 8358892 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1343

Taking stuff off of Irakli's queue where possible.
Attachment #8358892 - Flags: review?(rFobic) → review?(jsantell)
Comment on attachment 8358892 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1343

Some comments and nits on the bug -- should also remove the actual observer-service source/tests as well if it's not being used anywhere else. If the comments look good, r+!
Attachment #8358892 - Flags: review?(jsantell) → review+
From Bug 943155, a test failure for backgroundify, gozala says just to remove it and the tests, so that can be closed once this is resolved.
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/a1e41d34efa42fe8e1273fa0df9f9c543881ce96
Bug 958908 - Remove usage of deprecated/observer-service

https://github.com/mozilla/addon-sdk/commit/abf04cd306f7bfa7f9433a564a0474abff0bfa26
Merge pull request #1343 from erikvold/958908

Bug 958908 - Remove usage of deprecated/observer-service r=@jsantell
Merged, closing
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: