958957 - MathML href links do not appear in Firefox context menu

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Frédéric Wang Nélar]

Attachment: math.xhtml

See the testcase. 

MathML XLink links appear in the context menu but not MathML href links.

Comment 1

[Frédéric Wang Nélar]

Attachment: reftests

Comment 2

[Frédéric Wang Nélar]

Attachment: Patch

Comment 3

[Frédéric Wang Nélar]

MathML XLink have been removed in bug 1575870 but we should still make normal link work. Perhaps we should only focus on <a> now though

Comment 4

[Frédéric Wang Nélar]

Attachment: Bug 958957 - MathML href links do not appear in Firefox context menu. r=gijs

Fix ContextMenuChild.sys.mjs's _setContextForNodesWithChildren so that
it treats MathML elements with a href attributes as links. Contrary to
what is claimed in the code comments, it's currently not consistent with
hrefAndLinkNodeForClickEvent from browser.js or BrowserUtils.sys.mjs,
but that change makes the behavior slightly closer.

Note that these other code paths consider XLink href attributes on MathML
elements but support has been removed since bug 1575870, so we don't
copy that part, it will be removed in a follow-up patch.

Additionally, there is a plan to deprecate usage of href attributes on
most MathML elements but <a>, so the new tests consider this element
as well as the deprecated case.

Comment 5

[Frédéric Wang Nélar]

https://treeherder.mozilla.org/jobs?repo=try&revision=dee7b54a40071c29b02941b7208f9b1dd25240ac

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d0c4ecfc0db8
https://hg.mozilla.org/integration/autoland/rev/71489ed94b64
MathML href links do not appear in Firefox context menu. r=Gijs

Comment 7

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/71489ed94b64

Comment 8

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/71489ed94b64