958999 - Android content.css rules should be moved to widget and -moz-appearance so that author styles override them properly

Status: RESOLVED WORKSFORME

(GeckoView :: General, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Currently b2g/chrome/content/content.css and android/themes/core/content.css have rules like this:

/* Override inverse OS themes */
select,
textarea,
button,
xul|button,
* > input:not([type="image"]) {
  -moz-appearance: none !important;  /* See bug 598421 for fixing the platform */
  border-radius: 3px;
}

select[size],
select[multiple],
select[size][multiple],
textarea,
* > input:not([type="image"]) {
  border-style: solid;
  border-color: #7d7d7d;
  color: #414141;
  background: white linear-gradient(rgba(115,115,115,0.5) 0, rgba(215,215,215,0.5) 3px, rgba(255,255,255,0.2) 16px);
}

These are basically system themes for Android and B2G. If an author sets "textarea { border:2px solid black; }" or something like that, on our other platforms that disables all system theming, so they get square corners and no special background, as expected. But on Android/B2G that doesn't work and the author will unexpectedly get rounded corners and a gradient background.

You could argue that that's OK, but I think cross-platform consistency wins here.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Mass closing as we are no longer working on b2g/firefox os.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Mass closing as we are no longer working on b2g/firefox os.

Comment 3

[Markus Stange [:mstange]]

This still affects GeckoView. GeckoView's content.css is at mobile/android/themes/geckoview/content.css.

Comment 4

[David Lawrence [:dkl]]

Moving all open Core::Widget: Android bugs to GeckoView::General (then the triage owner of GeckoView will decide which ones are valuable and which ones should be closed).