Enable the non-native theme on Android Nightly
Categories
(Core Graveyard :: Widget: Android, defect)
Tracking
(firefox76 fixed)
Tracking | Status | |
---|---|---|
firefox76 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
(Depends on 1 open bug)
Details
Attachments
(3 files)
Android has their own UA sheets which cause a bunch of compat issues, and get people backed out because of silly rules there.
We could get rid of them if we had a proper native theme. And now we do!
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
I browsed a bit with it and it looks pretty nice. Should we consider enabling it
on Nightly so we find if there's any obvious problem?
Assignee | ||
Comment 2•3 years ago
|
||
Given the state of our form controls on android, this is probably an improvement
even without the things that block this on desktop. Let's try this out.
Depends on D64396
Assignee | ||
Comment 3•3 years ago
|
||
The second patch needs some test adjustments, so will land the first for now.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/28024d6694a1 Support widget.disable-native-theme-for-content on Android, and don't apply geckoview.css in that case. r=snorp
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/94be7cf140e4 Add a missing include.
Comment 6•3 years ago
|
||
bugherder |
Assignee | ||
Comment 7•3 years ago
|
||
Tons of new passes, some fuzzy bits, and one failure from a test that makes bad
assumptions about themed and unthemed <input type=color> being equally tall.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b46e40872077 Enable widget.disable-native-theme-for-content on Android Nightly. r=snorp https://hg.mozilla.org/integration/autoland/rev/a2c3bd0e1fba Update WPT annotations. r=snorp
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/b0b0c4242976 Minor reftest annotation fixes.
Comment 10•3 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/760a89ae35a7 More fuzzy appearance test annotations.
Comment 11•3 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/e5be676f6f06 One fuzzy appearance test annotation.
Comment 12•3 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/c1a32c968550 Fix one test that was mistakenly changed to pass.
Comment 13•3 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/9448002ebec9 Temporarily skip one mochitest on android.
Comment 14•3 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/cea91b0cc4f9 Apparently literally all webkit-appearance reftests are intermittently fuzzy on android.
Comment 15•3 years ago
|
||
Backed out for mochitest failures on test_sanityEventUtils.html
Backout link: https://hg.mozilla.org/integration/autoland/rev/6f21f98dcfcd3420ea528c6ede104fd4d1d36e75
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=292369171&repo=autoland&lineNumber=5393
Comment 16•3 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1f8967fe76c1 Enable widget.disable-native-theme-for-content on Android Nightly. r=snorp https://hg.mozilla.org/integration/autoland/rev/471a9b797ac5 Update WPT annotations. r=snorp
Updated•3 years ago
|
Comment 17•3 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/e8b91e15f860 Some minor reftest annotation tweaks.
Comment 18•3 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/d0fe5c0f5ea4 Another test annotation.
Comment 19•3 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/ed67383e77a7 Mark the previously annotated test as random as it fails in opt but passes in debug (o.O)
Comment 20•3 years ago
|
||
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eaac96bf8116 Test annotation. r=emilio
Comment 21•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1f8967fe76c1
https://hg.mozilla.org/mozilla-central/rev/471a9b797ac5
https://hg.mozilla.org/mozilla-central/rev/e8b91e15f860
https://hg.mozilla.org/mozilla-central/rev/d0fe5c0f5ea4
https://hg.mozilla.org/mozilla-central/rev/ed67383e77a7
https://hg.mozilla.org/mozilla-central/rev/eaac96bf8116
Assignee | ||
Comment 22•3 years ago
|
||
Yay
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Updated•2 years ago
|
Description
•