1618202 - Enable the non-native theme on Android Nightly

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Android has their own UA sheets which cause a bunch of compat issues, and get people backed out because of silly rules there.

We could get rid of them if we had a proper native theme. And now we do!

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1618202 - Support widget.disable-native-theme-for-content on Android, and don't apply geckoview.css in that case. r=snorp

I browsed a bit with it and it looks pretty nice. Should we consider enabling it
on Nightly so we find if there's any obvious problem?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1618202 - Enable widget.disable-native-theme-for-content on Android Nightly. r=snorp

Given the state of our form controls on android, this is probably an improvement
even without the things that block this on desktop. Let's try this out.

Depends on D64396

Comment 3

[Emilio Cobos Álvarez (:emilio)]

The second patch needs some test adjustments, so will land the first for now.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28024d6694a1
Support widget.disable-native-theme-for-content on Android, and don't apply geckoview.css in that case. r=snorp

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94be7cf140e4
Add a missing include.

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/28024d6694a1
https://hg.mozilla.org/mozilla-central/rev/94be7cf140e4

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1618202 - Update WPT annotations. r=snorp

Tons of new passes, some fuzzy bits, and one failure from a test that makes bad
assumptions about themed and unthemed <input type=color> being equally tall.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b46e40872077
Enable widget.disable-native-theme-for-content on Android Nightly. r=snorp
https://hg.mozilla.org/integration/autoland/rev/a2c3bd0e1fba
Update WPT annotations. r=snorp

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0b0c4242976
Minor reftest annotation fixes.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/760a89ae35a7
More fuzzy appearance test annotations.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5be676f6f06
One fuzzy appearance test annotation.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1a32c968550
Fix one test that was mistakenly changed to pass.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9448002ebec9
Temporarily skip one mochitest on android.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cea91b0cc4f9
Apparently literally all webkit-appearance reftests are intermittently fuzzy on android.

Comment 15

[Narcis Beleuzu [:NarcisB]]

Backed out for mochitest failures on test_sanityEventUtils.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/6f21f98dcfcd3420ea528c6ede104fd4d1d36e75
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=292369171&repo=autoland&lineNumber=5393

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f8967fe76c1
Enable widget.disable-native-theme-for-content on Android Nightly. r=snorp
https://hg.mozilla.org/integration/autoland/rev/471a9b797ac5
Update WPT annotations. r=snorp

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8b91e15f860
Some minor reftest annotation tweaks.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0fe5c0f5ea4
Another test annotation.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed67383e77a7
Mark the previously annotated test as random as it fails in opt but passes in debug (o.O)

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eaac96bf8116
Test annotation. r=emilio

Comment 21

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/1f8967fe76c1
https://hg.mozilla.org/mozilla-central/rev/471a9b797ac5
https://hg.mozilla.org/mozilla-central/rev/e8b91e15f860
https://hg.mozilla.org/mozilla-central/rev/d0fe5c0f5ea4
https://hg.mozilla.org/mozilla-central/rev/ed67383e77a7
https://hg.mozilla.org/mozilla-central/rev/eaac96bf8116

Comment 22

[Emilio Cobos Álvarez (:emilio)]

Yay