959124 - Implement RemoteBitmapImage::GetAsSourceSurface

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Ali Ak]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36

Steps to reproduce:

Implement RemoteBitmapImage::GetAsSourceSurface to do what CairoImage::DeprecatedGetAsSurface does for a SourceSurface

Comment 1

[Ali Ak]

Attachment: Implement RemoteBitmapImage::GetAsSourceSurface

Just added a subclass specific implementation of GetAsSourceSurface.

Comment 2

[Ali Ak]

try: https://tbpl.mozilla.org/?tree=Try&rev=84e411f839ad

Comment 3

[Nicolas Silva [:nical]]

Comment on attachment 8359688 [details] [diff] [review]
Implement RemoteBitmapImage::GetAsSourceSurface

Review of attachment 8359688 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ImageContainer.cpp
@@ +677,5 @@
>  
> +TemporaryRef<gfx::SourceSurface>
> +RemoteBitmapImage::GetAsSourceSurface()
> +{
> +  gfxImageFormat fmt = RemoteImageData::BGRX32 ? gfxImageFormatRGB24 : gfxImageFormatARGB32;

I think you meant:
gfxImageFormat fmt = mFormat == RemoteImageData::BGRX32 ? gfxImageFormatRGB24 : gfxImageFormatARGB32;

Also, please replace the gfxImageFormat constants above by the Moz2D ones since the only thing you'll do immediately after is convert them to Moz2D's SurfaceFormat.

Comment 4

[Ali Ak]

Attachment: Implement RemoteBitmapImage::GetAsSourceSurface. r=nical.

Just added a subclass specific implementation of GetAsSourceSurface.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3eb0b43bae64

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3eb0b43bae64