Closed Bug 959327 Opened 6 years ago Closed 6 years ago

Update tests are not running by default on the emulator

Categories

(Firefox OS Graveyard :: Emulator, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S2 (28feb)

People

(Reporter: robert.strong.bugs, Assigned: dhylands)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

While testing some update changes I noticed that the B2G emulator was not running the update tests anymore on try. I also checked mozilla-central and they aren't running there either. I have no idea when the build config for B2G changed so the tests no longer run but a cursory look makes it appear to be quite some time ago.

To verify the changes I changed the following
diff --git a/b2g/branding/official/configure.sh b/b2g/branding/official/configure.sh
--- a/b2g/branding/official/configure.sh
+++ b/b2g/branding/official/configure.sh
@@ -1,7 +1,6 @@
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 MOZ_APP_DISPLAYNAME=B2G
 ANDROID_PACKAGE_NAME=org.mozilla.b2g
-MOZ_UPDATER=
diff --git a/b2g/branding/unofficial/configure.sh b/b2g/branding/unofficial/configure.sh
--- a/b2g/branding/unofficial/configure.sh
+++ b/b2g/branding/unofficial/configure.sh
@@ -1,7 +1,6 @@
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 ANDROID_PACKAGE_NAME=org.mozilla.b2g_`echo $USER`
 MOZ_APP_DISPLAYNAME=B2G
-MOZ_UPDATER=
diff --git a/b2g/confvars.sh b/b2g/confvars.sh
--- a/b2g/confvars.sh
+++ b/b2g/confvars.sh
@@ -1,14 +1,16 @@
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 MOZ_APP_BASENAME=B2G
 MOZ_APP_VENDOR=Mozilla
+MOZ_UPDATER=1
+MOZ_PHOENIX=1
 
 MOZ_APP_VERSION=29.0a1
 MOZ_APP_UA_NAME=Firefox
 
 MOZ_UA_OS_AGNOSTIC=1
 
 MOZ_B2G_VERSION=1.4.0.0-prerelease
 MOZ_B2G_OS_NAME=Boot2Gecko

Try build with tests:
https://tbpl.mozilla.org/?tree=Try&rev=9e2ab05d60de
Are you sure we want MOZ_PHOENIX=1 ? Isn't it to identify desktop firefox?
I don't think it is needed.
So, sometime between the updater no longer being built and now the update tests started failing on debug emulator builds after the test has successfully completed during cleanup. I've tried a few things to isolate why by backing out some of the changes I've made to the tests over the last month but I really don't have the bandwidth or an emulator setup to diagnose it.

https://tbpl.mozilla.org/?tree=Try&rev=a289f7e8e728

Is there someone that can help figure this out?
Flags: needinfo?(fabrice)
Dave, can you help out here?
Flags: needinfo?(dhylands)
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #4)
> Dave, can you help out here?

Hey Robert,

Sure I can take a look. I also found some updater tests from bug 830780 that got r+'d and never landed, so I'm going to working on updater/emulator stuff soon anyways (I'll need to retest those tests and make sure that they still work).
Flags: needinfo?(dhylands)
Blocks: 971898
Target Milestone: --- → 1.4 S2 (28feb)
Assignee: nobody → dhylands
Depends on: 975560
Depends on: 983848
Currently, it looks like TBPL is running eng builds, which don't include the updater.

When I updated mozharness's write_b2g_config function (in b2g_build.py)

from:
        if device_name == 'generic':
            lines.append("LUNCH=full-eng")
to:
        if device_name == 'generic':
            lines.append("LUNCH=full-userdebug")

Then the xpcshell tests run, but fail due to bug 983848.

See the orange X here:
https://tbpl.mozilla.org/?tree=Ash&rev=53d894de9425
on the B2G ICS Emulator Debug (i.e. very last) line.
Depends on: 988410
Flags: needinfo?(fabrice)
Now that bugs 988410 and 983848 have landed on m-c, I tried this patch on ash and the emulator xpcshell tests are now green (and the updater tests are running).
https://tbpl.mozilla.org/?tree=Ash&rev=e8887b681ac9

The updater is normally enabled in user and userdebug builds. This enables the updater in the eng builds used on TBPL.
Attachment #8403761 - Flags: review?(jgriffin)
Comment on attachment 8403761 [details] [diff] [review]
Enable updater in emulator builds.

Review of attachment 8403761 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #8403761 - Flags: review?(jgriffin) → review+
Depends on: 994926
This seems to be working (I checked some xpcshell logs and I see the updater tests running), so marking as resolved/fixed.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.