959340 - [Gaia][Systems] Downloads API should have mochi test for resuming downloads

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Aus Lacroix [:aus]]

The mochi test for resuming downloads didn't actually test successful resuming of downloads. I've updated the test so that under normal operation the download SHOULD resume and if it doesn't then it fails.

Comment 1

[Aus Lacroix [:aus]]

Attachment: bug959340-downloads-api.patch

Comment 2

[Gregor Wagner [:gwagner]]

Comment on attachment 8359404 [details] [diff] [review]
bug959340-downloads-api.patch

Review of attachment 8359404 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/downloads/tests/serve_file.sjs
@@ +97,5 @@
> +    // of bytes only (minus the start offset).
> +    if (total && total < size) {
> +      size = total - offset;
> +    }
> +    else if (offset) {

nit: We usually put the else in the same line with '}'

Comment 3

[Aus Lacroix [:aus]]

Attachment: Patch - Final - bug959340-downloads-api.patch

r=gwagner, patch updated with final commit message, one nit addressed.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/45c1cc6df259

Please update your Hg config to include your name on your patches as well.

Comment 5

[Aus Lacroix [:aus]]

Will do, thanks Ryan! :)

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/45c1cc6df259