959425 - [B2G][Notification Bar] Data Usage Bar allows touch events behind it.

Status: RESOLVED DUPLICATE of bug 961047

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Peter Bylenga [:PBylenga]]

Attachment: DataUsage_Bar_log.txt

Description:
After dragging down the Notification bar, tapping on the Data Usage Bar permits a touch event behind it activating onClick events. Issue can be most easily reproduced with selection boxes that can be lined up in the background with the Data Usage Bar. Issue reproduces with and without APZ enabled and does not occur with other areas or buttons on the Notification bar.

Repro Steps:
1) Updated Buri to Build ID: 20140113004002
2) Navigate to Developer Options in Settings
3) Drag down Notification Bar
4) Tap Data Usage Bar
5) Switch back to Settings via Task Manager (Long press Homescreen button)
6) Observe Developer option that would have been behind Data Usage Bar

Actual:
Developer option was toggled when Data Usage Bar was tapped

Expected:
Developer option was not toggled when Data Usage Bar was tapped

Environmental Variables
Device: Buri v1.3 Mozilla RIL
Build ID: 20140113004002
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/5bb1837de7c0
Gaia: b3fc4f712562ee92b0ed0bd17abc61be9a36a8da
Platform Version: 28.0a2
Firmware Version: v1.2-Device

Notes:
Repro frequency: 5/5, 100%
See attached: logcat

Comment 1

[Peter Bylenga [:PBylenga]]

This issue does NOT reproduce on v1.2

Environmental Variables
Device: Buri v1.2 COM RIL
Build ID: 20140113004002
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/e672faf1e6a1
Gaia: 539a25e1887b902b8b25038c547048e691bd97f6
Platform Version: 26.0
RIL Version: 01.02.00.019.102 
Firmware Version: v1.2-device

Comment 2

[Jason Smith [:jsmith]]

This is a DOM bug I think. Maybe event fluffing?

Comment 3

[Sarah Parsons]

This issue started to occur on the Buri 1.3 Build ID: 20140110004009

Gaia   c606b129a2d1647c0fc7bfb197555026e9b27f9e
SourceStamp c5109884ae3a
BuildID 20140110004009
Version 28.0a2

Last working Buri 1.3 Build ID: 20140109004002

Gaia   22bc6be5b76cdc6d4e9667ff070979041a20ce2f
SourceStamp 2c8f8683bd0d
BuildID 20140109004002
Version 28.0a2

Comment 4

[Preeti Raghunath(:Preeti)]

1.3+ for regression

Jet,

Please help reassign from event fluff pov

Comment 5

[Jet Villegas (inactive)]

Are we certain event fluffing is the root cause here? That is, has someone tried turning it off?

https://bugzilla.mozilla.org/attachment.cgi?id=784630&action=diff

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Jet Villegas (:jet) from comment #5)
> Are we certain event fluffing is the root cause here? That is, has someone
> tried turning it off?
> 
> https://bugzilla.mozilla.org/attachment.cgi?id=784630&action=diff

This bug is an APZC thing not a fluffing thing. I think I know why.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug959425.patch

First patch I have in mind.

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8361161 [details] [diff] [review]
bug959425.patch

Seems like there is a race.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug959425.patch

v2 of the patch.

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8361181 [details] [diff] [review]
bug959425.patch

Review of attachment 8361181 [details] [diff] [review]:
-----------------------------------------------------------------

Hope one day we don't need to treat cost control that differently.

Comment 11

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/a9b0aca976cd9fe4c44546a9f9c1eaee6b25f59d

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1.3.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.3, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.3
  git cherry-pick -x -m1 a9b0aca976cd9fe4c44546a9f9c1eaee6b25f59d
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Good thing because this was the likely cause of frequent marionette-webapi failures on b2g-inbound. Reverted.
Master: 7f540e37cf0a02da9c88228c1b4627b923009cdf

https://tbpl.mozilla.org/php/getParsedLog.php?id=33182750&tree=B2g-Inbound

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Green post-backout.

Comment 15

[Kevin Grandon :kgrandon]

FYI - Travis was pretty unhappy with this as well. Might want to run it a few times before re-landing.

Comment 16

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Kevin Grandon :kgrandon from comment #15)
> FYI - Travis was pretty unhappy with this as well. Might want to run it a
> few times before re-landing.

It was green for me :(

Comment 17

[Kevin Grandon :kgrandon]

Yeah, I think it was just causing intermittent failures. Around 50% or so, but maybe some gecko patch landed that causes this to flare up more?

Comment 18

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Can we have a platform bug in file when we workaround this in Gaia System? Thanks.

Comment 19

[Kartikaya Gupta (email:[e-mail])]

If my understanding of the current situation is right, the approach being considered in bug 961047 should fix this bug as well. Inverting dependency relationship since we're more likely to do that.

Comment 20

[Preeti Raghunath(:Preeti)]

Please review for dependency on 961047 - https://bugzilla.mozilla.org/show_bug.cgi?id=961047

Comment 21

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Kats understanding is right. The patch from bug 961047 should obsolete this patch.

Tim the platform fix is coming.