959845 - Disable the network API on desktop

Status: RESOLVED DUPLICATE of bug 1020758

(Core :: DOM: Core & HTML, task, P5)

Description

[(no longer active)]

I'm not sure why dom.network.enabled is true everywhere, it seems like that was done in bug 677166 without much discussion.  Jonas, do you agree that we should restrict this to b2g for now?

Comment 1

[Florian Bender]

I don't see much reason to not enable it everywhere. In the interest of cross-device compat, it should remain enabled everywhere, even if it does not make that much sense on most desktop systems (but maybe on notebooks with 3G modems if this is recognized).

Comment 2

[(no longer active)]

Well, we're looking into alternate APIs right now, so we're clearly not ready to expose anything here to the broader web I think.

Comment 3

[Florian Bender]

Are there overlapping parts for the implemented vs the alternate APIs? In this case, I'd expose the overlapping parts (because they seem to have consensus) and remove all other parts.

Comment 4

[(no longer active)]

(In reply to comment #3)
> Are there overlapping parts for the implemented vs the alternate APIs? In this
> case, I'd expose the overlapping parts (because they seem to have consensus)
> and remove all other parts.

The new proposal is under navigator.netInfo.  But the reason why I filed this bug was that our desktop implementation just returns bogus values.  We have a real implementation on Android but it's not clear to me if we want to keep that around as well, and it would be nice if we could eventually avoid exposing both versions of this API.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

We should definitely remove this API from platforms where at least .bandwidth is implemented. The implementations that just return hardcoded values don't seem to add any value.

I thought that we only had an implementation on Android right now. I.e. that even B2G wasn't implemented? Bug 796539 is still marked as unfixed, which indicates that's the case.

If so, I think we should disabled this API everywhere except for Android.

Comment 6

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

ehsan, do you recall which network API this bug is/was about. Some b2g thingie or https://searchfox.org/mozilla-central/source/dom/webidl/NetworkInformation.webidl
I think some b2g.

Comment 8

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/ae8a5c6d6340 suggests that this pref used to control the navigator.mozConnection API.

Comment 9

[Kohei Yoshino]

This has already been done with Firefox 31.