put log length on a new line

ASSIGNED
Assigned to

Status

Release Engineering
General
ASSIGNED
4 years ago
10 months ago

People

(Reporter: heycam, Assigned: heycam)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2291] )

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 8360201 [details] [diff] [review]
patch

The change to log length error message in bug 958327 made it awkward for sheriffs finding the generic "log length exceeded" bug on tbpl.  philor suggested putting the amount the log was exceeded by on a new line, matching the existing regex so that it is included in the bug comment.
Attachment #8360201 - Flags: review?(catlee)
Comment on attachment 8360201 [details] [diff] [review]
patch

You've got two parameters for string interpolation in the 2nd line, but only one value being passed in.

Do you want something like

"Output was %i bytes (exceeded limit by %i bytes)" % (self.nonHeaderLength, self.nonHeaderLength - self.logMaxSize)

?
Attachment #8360201 - Flags: review?(catlee) → review-
Created attachment 8361352 [details] [diff] [review]
patch v2

I did mean to put another value in there, yes.  (No way for me to test locally obviously!)  But the second line needs to begin with "Output exceeded ... bytes" so that the tbpl regexes pick it up.
Attachment #8360201 - Attachment is obsolete: true
Attachment #8361352 - Flags: review?(catlee)

Updated

4 years ago
Attachment #8361352 - Flags: review?(catlee) → review+

Updated

3 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2279]

Updated

3 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2279] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2288]

Updated

3 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2288] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/2291]
Component: Tools → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.