959996 - JavaScript Error: "TypeError: thumbnailList is undefined" {file: "app://video.gaiamobile.org/gaia_build_defer_index.js"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

E/GeckoConsole(  613): [JavaScript Error: "TypeError: thumbnailList is undefined" {file: "app://video.gaiamobile.org/gaia_build_defer_index.js" line: 525}]

This happens after starting up the emulator, tested with the jb version of the emulator in pvt builds, with timestamp 20140114154437, then launching the Videos app.

Not sure how to move this forward, setting needinfo? from David, the Gaia::Video module owner.

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

I know what's going on. We used the screenlayoutchange event to do some UI updates instead of resize event because there is multiple resize events in firefox nightly when we rotate the simulator. After APZ is enabled by default, the sequence of screenlayoutchange is different than before.

At first, we don't have screenlayoutchange event at the app start-up. So, we may add some code to check if it is under start-up procedure to prevent that or to use resize event but need to check the rotation issue of simulator.

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

The screenlayoutchange event is built from the change event of MediaQueryListListener. I should mention it in comment 1.

Comment 3

[vsireesha246]

Attachment: Pointer to Pull Request.html

Hi John,

I added the check condition as per our discussion in IRC.
Please review and let me know the review comments.

Thanks,
Sireesha.

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8362400 [details]
Pointer to Pull Request.html

Thanks for this patch.

I had filed a bug 961636 to address the additional resize events while app starts up. That's the root cause of this bug. But I would like to land the this workaround patch to get rid of ugly error log.

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/7bd157d797cca114c51401170ca1c8d366be9551