96008 - <radiogroup> implementation sucks!

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[David Hyatt]

The current implementation of <radiogroup> makes the assumption that the 
<radiogroup> has an id.  This is fundamentally flawed.  The impl relies on 
setting "group" attributes on every <radio> elt in the group.

This is slow slow slow! :)  

If this is an attempt to deal with nested radio groups, then a helper function 
should just be written to walk the content model obtaining the group elts and 
skipping nested <radiogroup>s.  It will perform way better than what's there 
now, since the current impl is using getElementsByAttribute, which will waste 
time crawling into the nested radio groups.

Comment 1

[Blake Ross]

--> me

Comment 2

[[e-mail]]

Would it be worthwile cacheing the list of radiobuttons as a property?
<property name="radiobuttons">
  this.getElementsByAttribute("radio", this.id);
</property>
Or just require ids on outer radiogroups:
<property name="radiobuttons">
  this.getElementsByTagName("radiogroup").length ?
    this.getElementsByAttribute("radio", this.id) :
    this.getElementsByTagName("radio");
</property>

Comment 3

[[e-mail]]

Is this a bup of bug 96019?

Comment 4

[Blake Ross]

Fixed.