960114 - Multiple CSS warnings shown when launching the Gallery app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

+++ This bug was initially created as a clone of Bug #959994 +++

E/GeckoConsole(  652): [JavaScript Warning: "Expected end of selector or a user action pseudo-class after pseudo-element but found '.'.  Ruleset ignored due to bad selector." {file: "app://gallery.gaiamobile.org/style/gallery_tablet.css" line: 441 column: 89 source: "  section[role="region"].skin-dark > header:first-child menu[type="toolbar"] button:after."}]
E/GeckoConsole(  652): [JavaScript Warning: "Function token for non-function pseudo-class or pseudo-element, or the other way around, when reading 'not'.  Ruleset ignored due to bad selector." {file: "app://gallery.gaiamobile.org/style/gallery_tablet.css" line: 645 column: 7 source: "  body:not[.fullscreenView] .videoPlayerPauseButton {"}]
E/GeckoConsole(  652): [JavaScript Warning: "Function token for non-function pseudo-class or pseudo-element, or the other way around, when reading 'not'.  Ruleset ignored due to bad selector." {file: "app://gallery.gaiamobile.org/style/gallery_tablet.css" line: 649 column: 7 source: "  body:not[.fullscreenView] .videoPlayerSlider {"}]
E/GeckoConsole(  652): [JavaScript Warning: "Function token for non-function pseudo-class or pseudo-element, or the other way around, when reading 'not'.  Ruleset ignored due to bad selector." {file: "app://gallery.gaiamobile.org/style/gallery_tablet.css" line: 653 column: 7 source: "  body:not[.fullscreenView] .videoPlayerProgress {"}]
E/GeckoConsole(  652): [JavaScript Warning: "Function token for non-function pseudo-class or pseudo-element, or the other way around, when reading 'not'.  Ruleset ignored due to bad selector." {file: "app://gallery.gaiamobile.org/style/gallery_tablet.css" line: 658 column: 7 source: "  body:not[.fullscreenView] .videoPlayerSlider .videoPlayerDurationText {"}]

This happens after starting up the emulator, tested with the jb version of the emulator in pvt builds, with timestamp 20140114154437, then launching the Gallery app.

Not sure how to move this forward, setting needinfo? from David, the Gaia::Gallery module owner.

Comment 1

[David Flanagan [:djf]]

These are all actually CSS warnings, even though they say "JavaScript" in them. Editing the bug title to reflect that.

All are in the file gallery_tablet.css, which was introduced recently by George Duan.

George: can you take a look at these errors when you have a chance?

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

They should be body:not(.fullscreenView) instead of body:not[.fullscreenView]. I should find it at the review procedure. Sorry about that.

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi David,
It's my fault.
I think we probably need a css checker in travis. 

Please kindly help to check this patch.
Thanks.

Comment 4

[David Flanagan [:djf]]

Comment on attachment 8361631 [details]
PR to master

Looks good.  Sorry my review took so long.

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks,
master: https://github.com/mozilla-b2g/gaia/commit/f938e2c0782a667f1a3476604a673c07d28eb5ce