960235 - switching away from Fennec and then back causes Marketplace content to disappear

Status: VERIFIED FIXED

(Marketplace Graveyard :: General, defect, P1)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: screenshot showing page after returning to Fennec

After loading marketplace.firefox.com in Fennec, if I press the Android device's Home button to go to the homescreen and then return to Fennec, then Marketplace's content disappears and is replaced by a blank gray background with a little bit of Marketplace navigation at the top (specifically: the search bar and the categories bar).

I see this with the latest Fennec nightly as well as older Fennec nightlies (and various custom builds I've produced).  It isn't clear whether it's a Fennec draw/paint bug or a Marketplace bug (f.e. a reaction to some event like pageshow that fires when I return to Fennec), but I'm filing it in the Marketplace product for now with some Fennec hackers cc:ed.

The bug is particularly noticeable on Fennec builds that have synthetic APKs enabled, since the synthetic APK install process switches away from Marketplace to a native Android "confirm install" dialog, and the bug occurs when you switch back.

But it happens even with synthetic APKs disabled, and it happens on builds from before I landed support for synthetic APKs last week, so it is *not related* to synthetic APKs.

Comment 2

[Ioana Chiorean]

Starting with Synthetic APKs this got worse as you can see it more often:

Steps:
1. Install any app 
2. After the installation success screen (Open/Done buttons screen) press back to get back in Fennec

The marketplace will be blank. A refresh page is needed.

Comment 4

[Andy McKay]

This got bumped to P1 and a target milestone added by cvan, but no-one took it work on it. Would someone be able to do that?

Comment 5

[krupa raj[:krupa]]

Sometimes the categories landing page is also blank upon loading.

Comment 6

[Kevin Ngo [:ngoke]]

I ran into the cause.

Comment 8

[Kevin Ngo [:ngoke]]

https://bugzilla.mozilla.org/show_bug.cgi?id=917592

Regressed due to the fix that allows the Install/Launch to refresh state after a user installs/deletes an app. Fireplace rebuilds the page every time the user navigates away and back (via tab switch or app window change), but doesn't re-fetch deferred content.

The behavior should change to only rebuild the install button rather than rebuild the whole page on visibility change.

Comment 10

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/fireplace/pull/367/

Relevant STRs:

https://bugzilla.mozilla.org/show_bug.cgi?id=970641

https://bugzilla.mozilla.org/show_bug.cgi?id=917592

Comment 12

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/fireplace/pull/367

Comment 13

[krupa raj[:krupa]]

Attachment: screenshot

STR:
1. Load https://marketplace-dev.allizom.org on firefox mobile
2. Load the app details page 
3. Hit Back button to load the homepage 

observed behavior:
Homepage is blank upon loading

ashes: 4128c

Comment 14

[krupa raj[:krupa]]

(In reply to krupa raj[:krupa] from comment #13)
> Created attachment 8375138 [details]
> screenshot
> 
> STR:
> 1. Load https://marketplace-dev.allizom.org on firefox mobile
> 2. Load the app details page 
> 3. Hit Back button to load the homepage 
> 
> observed behavior:
> Homepage is blank upon loading
> 
> ashes: 4128c

Note that I had to browse around for a while before I hit this issue.

Comment 15

[Kevin Ngo [:ngoke]]

Is that related to this bug? Marketplace seems to be having numerous issues on Firefox Mobile for Android.

Comment 16

[krupa raj[:krupa]]

I filed https://bugzilla.mozilla.org/show_bug.cgi?id=972068

Comment 17

[Victor Carciu]

I was not able to reproduce the issues described in original scenario or comment #2 .
Ioana , can you please confirm that the issue is not reproducible anymore in order to close the bug?

Comment 18

[Teodora Vermesan (:TeoVermesan)]

Yes, the issue is not reproducible on latest Nightly 02/14 using LG Nexus 4 (Android 4.4.2) with different apps installed.

Comment 19

[Victor Carciu]

Thank you Teodora!
Verified as fixed.