Closed
Bug 960252
Opened 12 years ago
Closed 12 years ago
Refactor start page styles into a separate file
Categories
(Firefox for Metro Graveyard :: Theme, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 29
People
(Reporter: mbrubeck, Assigned: mbrubeck)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
43.77 KB,
patch
|
sfoster
:
review+
|
Details | Diff | Splinter Review |
Rather than have styles for Start.xul and browser.xul mixed together, we should split them into separate files.
This also renames our "other" browser.css to have a less confusing filename.
[The patch uses "hg cp" to preserve history of the lines moved from browser.css to start.css. This might make it hard to read in the Bugzilla review UI. You can view the patch "raw" if necessary.]
Project management note: This is not for v1; it's to enable some post-v1 work.
Attachment #8360627 -
Flags: review?(sfoster)
Comment 1•12 years ago
|
||
Comment on attachment 8360627 [details] [diff] [review]
patch
Review of attachment 8360627 [details] [diff] [review]:
-----------------------------------------------------------------
Looks much better. Tests pass too! We'll need to be careful about when we land this so we don't conflict too much, and/or complicate uplifting changes that might build on it
Attachment #8360627 -
Flags: review?(sfoster) → review+
| Assignee | ||
Comment 2•12 years ago
|
||
It's time. I don't think we're touching this code much more in v1, or that any resulting conflicts will be tricky to resolve:
https://hg.mozilla.org/integration/fx-team/rev/a5d86262abb3
Comment 3•12 years ago
|
||
Hi Matt, can you provide a point value.
Blocks: metrov1it23
Flags: needinfo?(mbrubeck)
Priority: -- → P2
QA Contact: jbecerra
Whiteboard: [defect] → [defect] p=0
| Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Marco Mucci [:MarcoM] from comment #3)
> Hi Matt, can you provide a point value.
This is a cleanup patch that's just been sitting in my queue forever and is not related to a story. I don't think there's any value in "estimating" it.
Flags: needinfo?(mbrubeck)
Comment 5•12 years ago
|
||
Thanks for the update Matt.
No longer blocks: metrov1it23
Whiteboard: [defect] p=0
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Updated•12 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•