Closed Bug 960317 Opened 10 years ago Closed 8 years ago

Remove "cross-slide" hack from APZC

Categories

(Core :: Panning and Zooming, defect)

Product:
Core
Component:
Panning and Zooming
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: mbrubeck, Assigned: kats)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch
10.39 KB, patch
botond
: review+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — — Splinter Review 
Bug 934750 added special APZC support for the Metro "cross-slide" gesture.  A new, more standard way to support this feature is the touch-action CSS property (bug 795567).  Once that is enabled by default (bug 960316) we can stop shipping this temporary hack.

This patch can't land until bug 960316 is fixed, but I wanted to test it now so I could verify that it works, and so we don't forget about this hack later.
Attachment #8360720 - Flags: review?(bugmail.mozilla)
Comment on attachment 8360720 [details] [diff] [review]
patch

Review of attachment 8360720 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Does it work as expected?
Attachment #8360720 - Flags: review?(bugmail.mozilla) → review+
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #1)
> LGTM. Does it work as expected?

Yup, works like a charm.
Whiteboard: [metro] [defect] → [metro] [defect] p=0
Hijacking this bug to remove cross-slide code now. It's not needed for metro any more, and it's not enabled on any platform (nor is it likely to be).
Assignee: mbrubeck → bugmail.mozilla
Summary: Remove "cross-slide" hack from APZC after touch-action CSS property is enabled → Remove "cross-slide" hack from APZC
Whiteboard: [metro] [defect] p=0
Attached patch Patch — — Splinter Review 

        Attachment #8360720 -
        Attachment is obsolete: true

        Attachment #8691564 -
        Flags: review?(botond)

    
    

    
  
Comment on attachment 8691564 [details] [diff] [review]
Patch

Review of attachment 8691564 [details] [diff] [review]:
-----------------------------------------------------------------

Nice :)

        Attachment #8691564 -
        Flags: review?(botond) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/b8533b00af0a
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox45:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45

          You need to log in
          before you can comment on or make changes to this bug.