96031 - Font size not applied to <li> element in some cases

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect, P1)

Description

[Erik Bruchez]

In the following example, the number displayed automatically by <li> doesn't
have the right font size (it keeps its default size):

<ol>
<font size="+1">
  <li>This is line 1
</font>
</ol>

If you write:

<font size="+1">
<ol>
  <li>This is line 1
</ol>
</font>

Then the size is what you would expect. Both cases work fine with Netscape 4 and IE.

Comment 1

[Pierre Saslawsky]

The list marker doesn't inherit (and never inherits) the font size from a HTML 
size attribute, although it does inherit the font-size from a style attribute.

I'm going to attach a testcase.  Note that what I'm seeing is slightly different 
from what the reporter described above. 

Reassigned to Layout/attinasi.

Comment 2

[Pierre Saslawsky]

Attachment: testcase

Comment 3

[Erik Bruchez]

Yes, for some reason the second case doesn't work either. I would have sworn
that it worked when I posted the bug.

Comment 4

[Hixie (not reading bugmail)]

This has nothing to do with inheritance, it's probably just that the parser
"fixes up" the markup differently. Sending to Parser to see what the content
model is doing in each case.

Comment 5

[Hixie (not reading bugmail)]

really sending...

Comment 6

[harishd]

I think this needs topembed consideration. Adding topembed keyword.

Comment 7

[harishd]

Attachment: Patch v1.1 [ Made LI's parent model to be flow ]

Comment 8

[harishd]

However, with the above patch the following sample renders differently. That is,
in IE the bullet ( unordered list ) seems to inherit all the properties ( I
think ) except "size" ( will open up a bug on this ) and LI seems to behave as
inline ( ref. bug 97330 ).

<ul>
<font size="+5" color="red">
<li>This is </li>line 1
</font>
</ul>

Comment 9

[Heikki Toivonen (remove -bugzilla when emailing directly)]

r=heikki

I think this should not be checked into the embedding branch unless it goes
together with the fixes to the regressions you noted. I'd like you to also check
the wrmb bugs in Bugscape to see if you can find any sites that have this problem. 

Comment 10

[vidur (gone)]

sr=vidur

Comment 11

[harishd]

FYI: I ran browser buster and found the following sites to have <font><li>
combination:
www.tomshardware.com   - no change in rendering
www.planetquake.com    - renders like IE ( watch for the bullets )
www.slashdot.org       - no change in rendering
cnnfn.cnn.com          - About three bullets render like IE rest unchanged (
refer to the testcase in bug 97351 )

Comment 12

[Asa Dotzler [:asa]]

a=asa on behalf of drivers.

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 47350 [details] [diff] [review]
Patch v1.1 [ Made LI's parent model to be flow ]

trying the 'has-approval' status for patches.

Comment 14

[Robert Kaiser]

the patch checked in for this one fixed bug 22899! yay!

Comment 15

[harishd]

Landed fix on 0.9.2 branch. Marking FIXED.

Comment 16

[Moied]

Verfied fixed on turnk Build ID 20011101