97351 - [FIX] bullets should not inherit "size" property for backwards compat.

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[harishd]

Self explanatory testcase:

<ul>
<font size="30pt" color="red">
<li> This text should be 30pt red. But the bullet should be the default size (
per IE )
</font>
</ul>

Comment 1

[harishd]

Forgot to mention:

You need to apply the patch in bug 96031 to see this problem. Without the patch
none of the properties would get inherited by the bullet.

Comment 2

[Marc Attinasi]

Marking topembed since this blocks a topembed bug (sigh).

Comment 3

[harishd]

With the patch in bug 96031 the bullet, refer to example 1, appears round in
shape and red in color ( just like IE ) however, if I make the SIZE to be a non
negative value, refer to example 2, then we render differently than IE. So, I'm
not sure whether we should or shouldn't ignore the SIZE attribute.

Example 1: <FONT color=red SIZE=-1><li><b>Recoded:</b>

Example 2: <FONT color=red SIZE=+1><li><b>Recoded:</b>

Comment 4

[harishd]

Attachment: Another testcase [ Applying font size thro' stylesheet - Testcase derived from cnnfn.cnn.com ]

Comment 5

[Marc Attinasi]

Add this to quirk.css

/* QUIRK: force bullet to be the default size for IE compatability
 */
*|*:-moz-list-bullet {
  font-size: -moz-initial;
}

This rule forces the bullet to be its initial size, regardless of the influence
of the <FONT> tag (in Quirks mode only).

Comment 6

[Marc Attinasi]

Tested also with OL - the numerals are indeed resized, as they are in IE - this
only changes the bullet behavior.

Comment 7

[Marc Attinasi]

OK, this patch is better for quirks.css

/* Quirk: prevent bullet from resizing with the list item
 *   see bug 97351
 */
*|li:-moz-list-bullet {
  font-size: -moz-initial;
}

Comment 8

[Pierre Saslawsky]

It should be:
  li:-moz-list-bullet
instead of
  *|li:-moz-list-bullet
even though quirk.css is only enabled for quirky html documents

r=pierre with that change

Comment 9

[Chris Waterson]

sr=waterson if you and pierre can agree on the selector. :-)

Comment 10

[Marc Attinasi]

Pierre is right - we do not need th universal namespace. Thanks.

Comment 11

[harishd]

Attachment: Testcase [ Fix for bug 96031 breaks, border,background,etc.. Need to address these issues too ]

Comment 12

[harishd]

Marc: I'm not sure if I need to open up a new bug to my last test case [
id=48192 ]. Please let me know if I have to. It looks like quirks.css needs
tweaking.

Comment 13

[Kevin McCluskey (gone)]

Updated status

Comment 14

[Marc Attinasi]

harish, that testcase is a different bug altogether! Please do open a new bug,
and if you have ideas about what needs to be tweaked include that too. Thanks.

Comment 15

[Marc Attinasi]

checked into trunk and 0.9.2 branch

Comment 16

[Marc Attinasi]

Nominating for 0.9.4

Comment 17

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin to MOZILLA_0_9_4_BRANCH

Comment 18

[Marc Attinasi]

Checked into 0.9.4 branch, marking FIXED

Comment 19

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This fix seems really wrong -- see bug 110360.  Isn't the right fix to parent
the bullet's style context (in quirks mode only?) to the parent of the block
whose bullet it is rather than to the block itself?  Or something like that?

Comment 20

[Marc Attinasi]

Having style context parentage differ from frame parentage is freightening to
me.  I think there are assumptions that the trees match, and only tables break
that AFAIK.

I can think of two other approaches: 

1) change the selector to
  ul > li:-moz-list-bullet {
    font-size: -moz-initial;
  }

2) change the pseudo used for numerals to -moz-list-numeral so we can
differentiate between the two cases.

In an email I received from Luke Stone, he suggested we hack the bullet sizing
code to implement the quirk.  Something like checking for quirks mode and then
using the default font size for the bullets rather than the size in the style
struct.  I personally prefer the child-selector approach, but only because it is
easier and it will allow me to go back to fixing the crashers I have on my plate.