Closed Bug 960381 (lockscreen-refactor) Opened 9 years ago Closed 5 years ago

[LockScreen] Refactor the lockscreen.js


(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Gonk (Firefox OS)
Not set


(Not tracked)



(Reporter: gweng, Unassigned)



Current LockScreen carries too much historical code, like:

1. IFRAME embedded camera/emergency panel
2. No clear animation controller
3. No clear states between panels switching
4. No clear way to plugin/unplugin different widgets and panels on the LockScreen. They now are all "hardcode" inside the LockScreen, except the sliding strategy which I had pulled out

Since I'm trying to solve 1. with SecureWindow and SecureWindowManager, the animation problem become more tricky. Because the original animation controller is scattered about CSS, "data-panel" attribute, and functions like unload panel and load panel.

I think we should invent a way to describe the animation and states changing process more clearly first, and then modularize the different components on the LockScreen, especially describe how them can be enable/disable and managed inside LockScreen. This should be a prerequisite of making LockScreen as an app.

I would not do all of these in this bug. I may fire other bugs to refactor it once a part.
NI Tim to discuss about priority. If there're other emergency things should be done, I would postpone this bug.
Flags: needinfo?(timdream)
Assignee: nobody → gweng
Component: Gaia::System → Gaia::System::Lockscreen
I will discuss this with you locally.
Flags: needinfo?(timdream)
I would start to solve this bugs (and fire sub-bugs) after I finished the Bug 951978.
Depends on: secure-window
Alias: lockscreen-refactor
No longer blocks: lockscreen-amd
Depends on: lockscreen-amd
Depends on: camera-helper
Depends on: clock-helper
Depends on: unlocker-helper
Depends on: conninfo-widget
Depends on: panel-mediator
Depends on: 975311
No longer blocks: lockscreen-as-app
Depends on: lockscreen-as-app
Assignee: gweng → nobody
Firefox OS is not being worked on
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.