960381 - (lockscreen-refactor) [LockScreen] Refactor the lockscreen.js

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

Current LockScreen carries too much historical code, like:

1. IFRAME embedded camera/emergency panel
2. No clear animation controller
3. No clear states between panels switching
4. No clear way to plugin/unplugin different widgets and panels on the LockScreen. They now are all "hardcode" inside the LockScreen, except the sliding strategy which I had pulled out

Since I'm trying to solve 1. with SecureWindow and SecureWindowManager, the animation problem become more tricky. Because the original animation controller is scattered about CSS, "data-panel" attribute, and functions like unload panel and load panel.

I think we should invent a way to describe the animation and states changing process more clearly first, and then modularize the different components on the LockScreen, especially describe how them can be enable/disable and managed inside LockScreen. This should be a prerequisite of making LockScreen as an app.

I would not do all of these in this bug. I may fire other bugs to refactor it once a part.

Comment 1

[Greg Weng [:snowmantw][:gweng][:λ]]

NI Tim to discuss about priority. If there're other emergency things should be done, I would postpone this bug.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I will discuss this with you locally.

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

I would start to solve this bugs (and fire sub-bugs) after I finished the Bug 951978.

Comment 4

[BMO Automation]

Firefox OS is not being worked on