Closed Bug 960915 (emergencycall-as-app) Opened 6 years ago Closed 6 years ago

[LockScreen][EmergencyCall] Make EmergencyCall as an app

Categories

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gweng, Assigned: gweng)

References

Details

Attachments

(2 files, 1 obsolete file)

46 bytes, text/x-github-pull-request
timdream
: review+
Details | Review
46 bytes, text/x-github-pull-request
Details | Review
Since we're implement SecureWindow to instead the embedded iframe, the emergency panel should be an standalone app, and follow the app creation/displaying/destroying logic to be managed.
Alias: emergencycall-as-app
Assignee: nobody → gweng
Attached file Patch (obsolete) —
* Move the original system/emergency-call from System to an individual app.
* Use SecureWindow mechanism to launch it in LockScreen.
Attachment #8377009 - Flags: review?(timdream)
Attached file Patch
New patch to bubble-tea because of the 1.4 landing policy.
Attachment #8377009 - Attachment is obsolete: true
Attachment #8377009 - Flags: review?(timdream)
Attachment #8380437 - Flags: review?(timdream)
Whiteboard: [in-bubble-tea]
Travis is green: https://travis-ci.org/mozilla-b2g/gaia/builds/19561555

I'll fix some minor issues and waiting review again.
Tim, since this bug is on the original v1.4 plan and should be done before 2/28, can you give me some feedback? Thanks.
Flags: needinfo?(timdream)
(In reply to Greg Weng [:snowmantw][:gweng][:λ] from comment #4)
> Tim, since this bug is on the original v1.4 plan and should be done before
> 2/28, can you give me some feedback? Thanks.

I would worry this is to much of a change for bubble-tea, but I might be wrong. Let's discuss this offline.
Flags: needinfo?(timdream)
Whiteboard: [in-bubble-tea]
Attachment #8380437 - Flags: review?(timdream) → review+
I'll land it after rebase and wait for the tests.
Status: NEW → ASSIGNED
Gareth's six questions:

- Is this a good idea?
> Yes. Since we have SecureWindow in LockScreen, we can finally remove all embedded iframes and to make them launched as an real app. While the camera is already an app, we need to make the emergency call as an app, too.

- What problem does it solve (and for whom)?
> As above.

- Is it high priority?
> Yes. Because this blocks the LockScreen refactoring plan I mentioned in dev-gaia.

- Are there any risks involved in doing this?
> I've tested with Travis (still on going) and manually tried it on my ZTE Open. But maybe there would be some regressions.

- Who should I ask for input?
> Still don't know what the 'input' is...

- Who should at least know that this is happening?
> Tim Guan-tin Chien
Oh, sorry for the inverted format. I'll correct it at the next bug.
Attached file New Patch
Since it's only different at the branch I want to merge, I keep the original one to show the r+ flag.
And I must mention about the opening and closing animation: Rob had discussed this with me, that he felt the old animation (from the right to left) would be confused with the Haida's sheet animation. So we should change secure apps' animation as it perform now (fade in/out).
master: https://github.com/mozilla-b2g/gaia/commit/8d9ba52b0340504acc024d0bfdd8717d674ab490

Hope it would be backed out.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
LOL would *NOT* be backed out.
lol, it's passed on the device CI Greg!
Thanks heaps for updating the tests :)
Great! And thanks for the information!
Depends on: 1030546
You need to log in before you can comment on or make changes to this bug.