960601 - Installing privileged app with origin in the manifest doesn't work

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Carmen Jimenez Cabezas]

STR:
1. Install any priviledged app from the marketplaces that specifies an origin on the manifest. For example the own marketplace app has that field on the manifest.

Expected:
The app is correctly installed and it has the correct origin

Actual:
The app isn't installed and there is an exception on the logcat:
E/GeckoConsole( 7224): [JavaScript Error: "Error while reading package:ReferenceError: app is not defined" {file: "resource://gre/modules/Webapps.jsm" line: 2981}]

This is a regression from bug 910815.

Comment 1

[Carmen Jimenez Cabezas]

Attachment: Proposed patch - v1

Comment 2

[Carmen Jimenez Cabezas]

Requesting block because this is a regression that landed in 1.3 and without this patch it would not be possible to install any priviledged apps with a custom origin on 1.3.

Comment 3

[[:fabrice] Fabrice Desré]

Comment on attachment 8361196 [details] [diff] [review]
Proposed patch - v1

Review of attachment 8361196 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, but we need tests to not regress that again.

Comment 4

[Antonio Manuel Amaya Calvo (:amac)]

(In reply to Fabrice Desré [:fabrice] from comment #3)
> Comment on attachment 8361196 [details] [diff] [review]
> Proposed patch - v1
> 
> Review of attachment 8361196 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> lgtm, but we need tests to not regress that again.

Shouldn't those tests be part of bug 880043? (Or they can be added after bug 880043 lands, since they're also signed packaged apps).

The other way to test this would be cheating a little bit... and testing it for Operator Single Variant Apps (aka locally installed apps) for which the signature verification is relaxed.

Comment 5

[Jason Smith [:jsmith]]

(In reply to Antonio Manuel Amaya Calvo (:amac) from comment #4)
> The other way to test this would be cheating a little bit... and testing it
> for Operator Single Variant Apps (aka locally installed apps) for which the
> signature verification is relaxed.

That would be better to have than having no tests at all. Can we add tests following this approach then?

Comment 6

[Antonio Manuel Amaya Calvo (:amac)]

I have added a test case for this on bug 880043 (on review now). As such, that bug depends on this being fixed now (since that test fails --correctly-- if this isn't fixed).

Comment 7

[Carmen Jimenez Cabezas]

Attachment: Proposed patch - v2

Resubmiting for review as per comment 6

Comment 8

[Carmen Jimenez Cabezas]

There is a green try run which included this patch and the unit test written at bug 880043 for it at:
https://tbpl.mozilla.org/?tree=Try&rev=e9cc593d8df8

Requesting checkin

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

https://hg.mozilla.org/integration/b2g-inbound/rev/a484e87093c2

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a484e87093c2

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ef4d9be503aa

Comment 12

[Ross Kuhlman ([e-mail])]

I downloaded and installed a variety of apps on my device that have origins in the manifests, and they all worked fine for me. Are there any specific apps that should be tested?

Tests run on todays master build: (2014/2/19)
Environmental Variables:
Device: Buri v1.4 Moz RIL
BuildID: 20140219040204
Gaia: ac06cfbd2baf6494ffbb668cc599e3892cd5e17b
Gecko: bf0e76f2a7d4
Version: 30.0a1
Firmware Version: v1.2-device.cfg

Comment 13

[Jason Smith [:jsmith]]

(In reply to rkuhlman from comment #12)
> I downloaded and installed a variety of apps on my device that have origins
> in the manifests, and they all worked fine for me. Are there any specific
> apps that should be tested?
> 
> Tests run on todays master build: (2014/2/19)
> Environmental Variables:
> Device: Buri v1.4 Moz RIL
> BuildID: 20140219040204
> Gaia: ac06cfbd2baf6494ffbb668cc599e3892cd5e17b
> Gecko: bf0e76f2a7d4
> Version: 30.0a1
> Firmware Version: v1.2-device.cfg

This is not right - you need to install an app that supports the origin property. Installing random packaged apps isn't going to allow you to verify this bug.

Comment 14

[Ross Kuhlman ([e-mail])]

Can you provide a specific example of an app that supports this property? No apps are indicated in the comments, and the marketplace does not appear to provide this info.

Comment 15

[Jason Smith [:jsmith]]

(In reply to rkuhlman from comment #14)
> Can you provide a specific example of an app that supports this property? No
> apps are indicated in the comments, and the marketplace does not appear to
> provide this info.

I'll look into this - don't worry about this.