Closed Bug 960673 Opened 6 years ago Closed 6 years ago

Improve Scrollgraph to Track Layer Position

Categories

(Core :: Graphics, defect, P1)

x86
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: mchang, Assigned: mchang)

References

Details

(Keywords: perf, Whiteboard: [c=automation p=3 s= u=][qa-])

Attachments

(3 files, 1 obsolete file)

Improve the Scroll Graph functionality introduced in bug 944866 to include layer position.
Blocks: 958592
No longer blocks: 958952
Attached patch scrollgraph.patch (obsolete) — Splinter Review
Changed to track the current layer's position based on the local transform of the layer instead of the visible region.
Attachment #8365448 - Flags: review?(bgirard)
Whiteboard: [c=automation p=4 s= u=] → [c=automation p=3 s= u=]
Comment on attachment 8365448 [details] [diff] [review]
scrollgraph.patch

Review of attachment 8365448 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/composite/ContainerLayerComposite.cpp
@@ +101,4 @@
>    std::vector<VelocityData> mData;
>  };
>  
> +static gfxPoint const GetScrollData(Layer* aLayer) {

Normally in mozilla code we do 'const T' instead of 'T const'.

I don't think it makes sense to have const here either.

@@ +139,4 @@
>      velocityData->mData.clear();
>    }
>  
> +  const gfxPoint layerTransform = GetScrollData(aLayer);

Its still helpful to have this as const however.
Attachment #8365448 - Flags: review?(bgirard) → review+
Found a bug, doesn't track the layer position for b2g correctly.
Carrying r+ from benwa.
Attachment #8365448 - Attachment is obsolete: true
Attachment #8368782 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/aff0cc866eb8
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Whiteboard: [c=automation p=3 s= u=] → [c=automation p=3 s= u=][qa-]
You need to log in before you can comment on or make changes to this bug.