960673 - Improve Scrollgraph to Track Layer Position

Status: RESOLVED FIXED

(Core :: Graphics, defect, P1)

Description

[Mason Chang [Inactive] [:mchang]]

Improve the Scroll Graph functionality introduced in bug 944866 to include layer position.

Comment 1

[Mason Chang [Inactive] [:mchang]]

Attachment: Thebes Layer while Scrolling a simple page

Comment 2

[Mason Chang [Inactive] [:mchang]]

Attachment: Scrollable Layer in Settings App w/ a Scroll

Comment 3

[Mason Chang [Inactive] [:mchang]]

Attachment: scrollgraph.patch

Changed to track the current layer's position based on the local transform of the layer instead of the visible region.

Comment 4

[Benoit Girard (:BenWa)]

Comment on attachment 8365448 [details] [diff] [review]
scrollgraph.patch

Review of attachment 8365448 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/composite/ContainerLayerComposite.cpp
@@ +101,4 @@
>    std::vector<VelocityData> mData;
>  };
>  
> +static gfxPoint const GetScrollData(Layer* aLayer) {

Normally in mozilla code we do 'const T' instead of 'T const'.

I don't think it makes sense to have const here either.

@@ +139,4 @@
>      velocityData->mData.clear();
>    }
>  
> +  const gfxPoint layerTransform = GetScrollData(aLayer);

Its still helpful to have this as const however.

Comment 5

[Mason Chang [Inactive] [:mchang]]

Found a bug, doesn't track the layer position for b2g correctly.

Comment 6

[Mason Chang [Inactive] [:mchang]]

Attachment: Scrollgraph Tracks Position on Sync / Desktop Scrolling.

Carrying r+ from benwa.

Comment 7

[Mason Chang [Inactive] [:mchang]]

TPBL: https://tbpl.mozilla.org/?tree=Try&rev=ff69845344d5

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aff0cc866eb8

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/aff0cc866eb8