961033 - Tagging bookmarks not allowed when tags have white spaces

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: General, defect)

Description

[Christian Ronquillo]

Attachment: firefox-beta-bookmark-taggin-problem.jpg

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20131216183647

Steps to reproduce:

1. Open Firefox beta for Android.
2. Open any site that is to be bookmarked.
3. Tap the Option button (i.e., beside the tab button) to display the options. 
4. Tap the star to bookmark the page.
5. The confirmation message "Bookmark added." notification shows up. Tap "Options" on the right-hand side to bring up more options.
6. Select "Edit".
7. Under the "Keyword" field, provide keywords with spaces (e.g., "a description", "john doe", etc.).
8. Observe that the OK button gets disabled.


Actual results:

The OK button gets disabled, preventing user from proceeding with bookmarking.

(Note: Please refer to attached screenshot)


Expected results:

The UI should have allowed the user to proceed with bookmarking by tagging the bookmark with said keywords with spaces.

(Note: Please refer to attached screenshot)

Comment 1

[Aaron Train [:aaronmt]]

The logic that handles this is here. I don't recall why the check? Wes?

http://hg.mozilla.org/mozilla-central/diff/684ba082942b/mobile/android/base/EditBookmarkDialog.java#l1.132

Comment 2

[Christian Ronquillo]

From my experience in desktop Firefox this isn't the case... For consistency's sake shouldn't be the behavior / experience be the same whether it's on desktop or mobile?

Comment 3

[Wesley Johnston (:wesj)]

This is from bug 856558. Note, keywords are different than tags (although I'm sure that's crazy confusing to users).

Comment 4

[Christian Ronquillo]

(In reply to Wesley Johnston (:wesj) from comment #3)
> This is from bug 856558. Note, keywords are different than tags (although
> I'm sure that's crazy confusing to users).

Oh alright. So basically "tagging" is not yet supported in Android Firefox? I mistook it (keywords) for tagging since it's the only one available in the Edit dialog.

Comment 5

[Christian Ronquillo]

Hi Aaron, noticed this is already considered marked resolved. However just have to push the question, so in this case, tagging isn't supported thus far? Isn't that supposed to be a bug?

Comment 6

[Aaron Train [:aaronmt]]

(In reply to Christian Ronquillo from comment #5)
> Hi Aaron, noticed this is already considered marked resolved. However just
> have to push the question, so in this case, tagging isn't supported thus
> far? Isn't that supposed to be a bug?

↳ bug 775672