961377 - Webapp runtime does not show tooltips

Status: RESOLVED FIXED

(Firefox Graveyard :: Webapp Runtime, defect, P2)

Description

[Jeroen van der Gun]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:26.0) Gecko/20100101 Firefox/26.0 (Beta/Release)
Build ID: 20131206145833

Steps to reproduce:

Install a desktop web app with tooltips (i.e. the HTML code includes title attributes).

Example app with tooltips on controls: http://calculabo.eu


Actual results:

When after installation, the app is run through the webapp runtime, the tooltips are not shown when hovering a control.


Expected results:

The application should show tooltips, identical to what happens when the same page is opened in the browser.

Comment 1

[Jeroen van der Gun]

I checked and observed the problem on Ubuntu as well as Windows XP.

Solution is probably simple extension of webapprt/content/webapp.xul with a tooltip element linked to the browser element:
https://developer.mozilla.org/en-US/docs/XUL/Attribute/tooltip.page

Comment 2

[Jeroen van der Gun]

Attachment: patch.patch

This patch enables tooltips in webapps.

This is my first code contribution to Mozilla; although building Firefox on my machine did not work, I tested the patch by placing an override in my chrome manifest, and the patch successfully fixed the bug.

Comment 3

[Marco Castelluccio [:marco]]

Comment on attachment 8362163 [details] [diff] [review]
patch.patch

Review of attachment 8362163 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you Jeroen.
I'm not sure this handles the case when there is a location change (the tooltip should be hidden when the location changes, see http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#3609).

You could ask in the introduction channel how to start building Mozilla code, it's really simple using mach (https://developer.mozilla.org/en-US/docs/Simple_Firefox_build).

Comment 4

[Jeroen van der Gun]

(In reply to Marco Castelluccio [:marco] from comment #3)
> I'm not sure this handles the case when there is a location change (the
> tooltip should be hidden when the location changes, see
> http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.
> js#3609).
Good catch. The patch needs some additional JavaScript to detect this to remove the tooltip in that case. (Hold your mouse on the info icon in my calculator app for three seconds a tooltip-preserving redirect to my homepage, where the normal Firefox browser would close the tooltip.)

Also, when looking at the code you pointed at, I found some other relevant stuff here on lines 131-145:
https://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.xul#131
* Formfill/password manager support does not seem relevant for webapprt, as apps will probably store credentials themselves e.g. in cookies, so this does not seem important to add now.
* Web apps have no url bar, so also no autocomplete in the url bar. :)
* What is ContentSelectDropdown for? Webapprt does not have it yet select elements function properly. (In my calculator app, click the settings icon and use the select dropdown.) Also, XUL tabbrowser element does not have a documented selectpopup attribute. [https://developer.mozilla.org/en-US/docs/XUL/tabbrowser]
* The webapprt indeed does not have form validation error popups. Lacking a mechanism to display errors, it apparently just submits the form. (In my calculator app, click the settings icon and try to set the output to base-1.) I'll try to add that to my patch as well.

> You could ask in the introduction channel how to start building Mozilla
> code, it's really simple using mach
> (https://developer.mozilla.org/en-US/docs/Simple_Firefox_build).
Thanks, but as the chrome manifest override works properly for testing solutions for this bug, I'll stick with that. :)

Comment 5

[Marco Castelluccio [:marco]]

(In reply to Jeroen van der Gun from comment #4)
> (In reply to Marco Castelluccio [:marco] from comment #3)
> > I'm not sure this handles the case when there is a location change (the
> > tooltip should be hidden when the location changes, see
> > http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.
> > js#3609).
> Good catch. The patch needs some additional JavaScript to detect this to
> remove the tooltip in that case. (Hold your mouse on the info icon in my
> calculator app for three seconds a tooltip-preserving redirect to my
> homepage, where the normal Firefox browser would close the tooltip.)
> 
> Also, when looking at the code you pointed at, I found some other relevant
> stuff here on lines 131-145:
> https://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.
> xul#131
> * Formfill/password manager support does not seem relevant for webapprt, as
> apps will probably store credentials themselves e.g. in cookies, so this
> does not seem important to add now.
> * Web apps have no url bar, so also no autocomplete in the url bar. :)
> * What is ContentSelectDropdown for? Webapprt does not have it yet select
> elements function properly. (In my calculator app, click the settings icon
> and use the select dropdown.) Also, XUL tabbrowser element does not have a
> documented selectpopup attribute.
> [https://developer.mozilla.org/en-US/docs/XUL/tabbrowser]
> * The webapprt indeed does not have form validation error popups. Lacking a
> mechanism to display errors, it apparently just submits the form. (In my
> calculator app, click the settings icon and try to set the output to
> base-1.) I'll try to add that to my patch as well.

You can also split the work in different bugs and just fix the tooltips here ;)

Comment 6

[Jeroen van der Gun]

(In reply to Marco Castelluccio [:marco] from comment #5)
> You can also split the work in different bugs and just fix the tooltips here
> ;)

You are probably right, as the form validation popup involves quite some code. And my limited Firefox development experience cannot make it work. I filed bug 961502 for someone else to pick that up.

I'll post the revised tooltip patch here soon.

Comment 7

[Jeroen van der Gun]

Attachment: patch v2

Tooltips now also close on location change

Comment 8

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Comment on attachment 8362275 [details] [diff] [review]
patch v2

I'm not super familiar with the code that was adapated from browser.js. Felipe (or another Fx front-end dev) should probably take a look

Comment 9

[Jeroen van der Gun]

Attachment: patch v2

Added reviewer name to commit message.

Comment 10

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/7d6daa084033

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7d6daa084033