Closed Bug 961574 Opened 7 years ago Closed 7 years ago

[Gaia][Messages] Display sent timestamp in received message report

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S2 (28feb)

People

(Reporter: steveck, Assigned: steveck)

References

Details

Attachments

(4 files, 1 obsolete file)

Based on the latest message app wireframe v8.0 page 25, we need to display the message sent timestamp for received message report(and with a differnt report layout). This issue is pure gaia work and need the additional message sent timetamp property landed in bug 901457.
Whiteboard: burirun1.3-2
To QA: this won't be in 1.3 as all the delivery report panel feature has been moved to 1.4.
Whiteboard: burirun1.3-2
Hi Jose,
In the wireframe spec v8.0 p.25, we need a different report layout for received message. Do you have a precise visual spec for the received message report layout? Thanks!
Flags: needinfo?(vittone)
Attached image SMS.MMS.Message_report_spec.png (obsolete) —
Hi Steve, actually the layout for recieved or sent message report is almost the same. From my point of view are only text changes, there's no new element or style on this variation. Attaching the message report SPEC, just in case.

Please tell me if you need something else.
Flags: needinfo?(vittone)
Well, in the WF page 25, the received message view is slightly different from the spec you gave. Received message will have sent/received timestamp at the bottom of the page and no delivery status at top.
Flags: needinfo?(vittone)
Attached file Link to github
Hi Borja, this is a sentTimestamp feature which already landed in gecko month ago. We need this for showing the received message sent timestamp in report view(and with some layout adjustment), thanks!
Attachment #8373927 - Flags: review?(borja.bugzilla)
Let make differences explicit. Here we go.
Attachment #8373330 - Attachment is obsolete: true
Flags: needinfo?(vittone)
Comment on attachment 8374831 [details]
SMS_MMS_messageReport.png

Hi Ayman, this visual seems different from your WF spec. Do we need to put the sent/receive timestamp inside the contact information block or outside the block?
Attachment #8374831 - Flags: feedback?(aymanmaat)
Comment on attachment 8374831 [details]
SMS_MMS_messageReport.png

(In reply to Steve Chung [:steveck] from comment #8)
> Comment on attachment 8374831 [details]
> SMS_MMS_messageReport.png
> 
> Hi Ayman, this visual seems different from your WF spec. Do we need to put
> the sent/receive timestamp inside the contact information block or outside
> the block?

Hey Steve. 

This visual is for received messages. If you refer to frame '3. Incoming message report' on page 25 of Wireframe pack FFOS_MessageApp_V1.3_20131125_V8.0 you will see the the visual Jose has provided actually has the same information structure as defined in the Wireframes.
Attachment #8374831 - Flags: feedback?(aymanmaat) → feedback+
Comment on attachment 8373927 [details] [review]
Link to github

R+!
Attachment #8373927 - Flags: review?(borja.bugzilla) → review+
Comment on attachment 8373927 [details] [review]
Link to github

Retesting because I've seen something weird in the tests.
Attachment #8373927 - Flags: review+ → review?(borja.bugzilla)
Steve, rebasing your code with master I found the following:

  1) [sms] SMS App Unit-Test Threads-list Threads-list rendering Render unread style properly:
     Error: expected 2 to equal 1
      at chaiAssert (http://sms.gaiamobile.org:8080/common/test/helper.js:33)
      at equal (http://sms.gaiamobile.org:8080/common/vendor/chai/chai.js:1250)
      at assertNumOfElementsByClass (http://sms.gaiamobile.org:8080/test/unit/sms_test.js:105)

Could you take a look? Thanks!
Flags: needinfo?(schung)
Actually I've seen this on "normal" master too, so maybe we should fix this in another bug.

Clearly this is strange because Travis is fine :(
Comment on attachment 8373927 [details] [review]
Link to github

Agree with Julien. Probably we should check why tests are failing and fix this in other bug. R+.

Steve, let's merge this when the branch will be ready
Attachment #8373927 - Flags: review?(borja.bugzilla) → review+
(In reply to Borja Salguero [Back to Gaia!] [:borjasalguero] from comment #14)
> Comment on attachment 8373927 [details] [review]
> Link to github
> 
> Agree with Julien. Probably we should check why tests are failing and fix
> this in other bug. R+.
> 
> Steve, let's merge this when the branch will be ready

Thanks, but it seems we have to wait for a long time for landing... :(
Flags: needinfo?(schung)
Target Milestone: --- → 1.4 S2 (28feb)
Landed in master: 3551052d34d6db3568091c3bc65a1a20a4625f71
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: 1.4 S2 (28feb) → ---
Target Milestone: --- → 1.4 S2 (28feb)
You need to log in before you can comment on or make changes to this bug.