961707 - Add cppunittests as option in TryChooser

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Dan Minor [:dminor]]

Currently the only way to run cpp unit tests on try is by running all tests. It would be good to have an option to run only the cpp unit tests.

Comment 1

[Dan Minor [:dminor]]

Might as well do this for the jit-tests at the same time.

Comment 2

[Dan Minor [:dminor]]

Should 'cppunittest' and 'jittest' just work without changes to the try syntax parser?

They don't seem to: https://tbpl.mozilla.org/?tree=Try&rev=ab1dda33eae6

Comment 3

[Phil Ringnalda (:philor)]

cppunit and jittest - not sure where your jit went, unless the parser throws away everything after an unrecognized option, which it might.

Comment 4

[Dan Minor [:dminor]]

Thanks, 'cppunit' works fine. 'jittest' doesn't seem to work which might be due to the way it is handled in the build configs (it is added where we want it to run, rather than being removed from where we don't want it to run.)

I'll just do cppunittests for now.

Comment 5

[Dan Minor [:dminor]]

Attachment: Add cppunit to trychooser page.

Comment 6

[Dan Minor [:dminor]]

Thanks, pushed to https://hg.mozilla.org/build/tools/rev/0c1f065025cb

Comment 7

[Phil Ringnalda (:philor)]

Oh, no wonder jittest didn't work for you when it did for me (on a -p all push), bug 969988.

Comment 8

[Dan Minor [:dminor]]

Appears to be broken for Android 4.

Comment 9

[Dan Minor [:dminor]]

Attachment: Add cppunittest to Android section of trychooser page

As Philor pointed out, we call these cppunittest instead of cppunit on Android so we need a separate line item in the Android section of the page.

Comment 10

[Dan Minor [:dminor]]

Thanks, pushed to: https://hg.mozilla.org/build/tools/rev/48ff10b10b22

Comment 11

[Phil Ringnalda (:philor)]

Wait, why are we making sure that nearly nobody will actually run them on Android, rather than fixing the name?

Comment 12

[Phil Ringnalda (:philor)]

There is actually an alternative to fixing the (broken, incorrect) name, though: just like the way http://mxr.mozilla.org/build/source/buildbotcustom/try_parser.py#14 works around "-u reftest" needing to match reftest, plain-reftest-8 and reftest-10, it could work around that stray unnecessary "test" without any need for a second checkbox nobody will ever remember to check until their second push.

Comment 13

[Dan Minor [:dminor]]

(In reply to Phil Ringnalda (:philor) from comment #11)
> Wait, why are we making sure that nearly nobody will actually run them on
> Android, rather than fixing the name?

Filed bug 980279 to get this fixed.

Comment 14

[Dan Minor [:dminor]]

Looks like the new option is working: https://tbpl.mozilla.org/?tree=Try&rev=ccd3a1fd98d7