961954 - GeckoApp.onCreatePanelMenu is called during startup

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

GeckoApp.onCreatePanelMenu is called from GeckoApp.initialize() for SDK >= 11 here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/GeckoApp.java#1432

GeckoApp.onCreatePanelMenu accounts for 8.2% (194ms) of startup on my Galaxy Nexus.

We moved the call to initialize() for some reason in bug 886528. Maybe we went too far.

Comment 1

[Richard Newman [:rnewman]]

Might be worth just testing this: stuff it last in the background thread initializers, and fast-init it when loading the menu.

Where's most of the time coming from? Looking up views by ID?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

It calls BrowserApp.onCreateOptionsMenu, which takes most of it's time in GeckoMenuInflater.inflate -> GeckoMenuInflater.parseMenu

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch v1

This just removes these calls. I still want to make sure that we invalidate the menu at some point, so I moved that into onMenuOpened. I also moved the event handlers into BrowserApp since they're not used by any one else (Ideally we'd move all this code into the menu code, but that's a bigger refactor).

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8369744 [details] [diff] [review]
Patch v1

I'd like you to test a few situations:
* Make sure a menu item correctly toggles (Bookmark and Request Desktop, for example)
* Test on Gingerbread, ICS and newer phones, since invalidateOptionsMenu is a 11+ API and menus worked differently before it.

Comment 5

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/f75bd697d570

Comment 6

[Wesley Johnston (:wesj)]

backed out: https://hg.mozilla.org/integration/fx-team/rev/6d962d016eae

Comment 7

[Wesley Johnston (:wesj)]

Attachment: Patch v2

Grr. Forgot to test on a device with a software menu button. Or... didn't realize that they were different. Pushed this to try:

https://tbpl.mozilla.org/?tree=Try&rev=dea89e3ff9c0

Comment 8

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/f69c9b69caab

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f69c9b69caab

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

GeckoApp.onCreatePanelMenu is no longer in the startup profile.

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

Let this bake a few more days, but we should consider moving this to Aurora. It's still early in the cycle.

Comment 12

[Aaron Train [:aaronmt]]

This might have caused regression bug 972327. Please convince me otherwise.

Comment 13

[Wesley Johnston (:wesj)]

Nope. It almost certainly caused that.