972327 - 'Refresh' and 'Bookmark' buttons are hidden from the url bar; appear on menu-tap

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Flaviu Cos]

Environment: 
Device: Asus Transformer Tab (Android 4.0.3);
Build: Nightly 30.0a1 (2014-02-13);

Steps to reproduce:
1. Launch fennec;
2. Verify if 'refresh' and 'bookmark' buttons are displayed.

Expected result:
'Refresh', 'Bookmark' and 'Options' buttons are displayed on the right side of the url bar.

Actual result:
Only the 'Options' button is displayed. 
'Refresh' and 'Bookmark' buttons are displayed only after tapping on the 'Options' button.

Note:
This bug is tablet specific.

Comment 1

[Flaviu Cos]

Last good revision: 1e9f169c9715 (2014-02-06)
First bad revision: dedf12c4e805 (2014-02-07)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1e9f169c9715&tochange=dedf12c4e805

Comment 2

[Aaron Train [:aaronmt]]

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=8d7c0ce1b376&tochange=e3b700ce10fc

f69c9b69caab	Wes Johnston — Bug 961954 - Lazy load main menu. r=mfinkle

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Patch 1

I'm debating what to do here a little, but a big part of me wants to just explicitly add these items to the actionbar on tablets.

This is the alternative, just initialize the menu on tablet devices. Its simple and we can land it now to fix the regression.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8376045 [details] [diff] [review]
Patch 1

This seems safe enough for now.

Comment 6

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/a12e6c2e9535

Comment 7

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/fx-team/rev/56172f02c23b for not actually building.

Comment 8

[Bill Gianopoulos [:WG9s]]

(In reply to Wesley Johnston (:wesj) from comment #4)
> Created attachment 8376045 [details] [diff] [review]
> Patch 1
> 
> I'm debating what to do here a little, but a big part of me wants to just
> explicitly add these items to the actionbar on tablets.
> 
> This is the alternative, just initialize the menu on tablet devices. Its
> simple and we can land it now to fix the regression.

I get the following error trying to build with this patch:

/home/wag/mozilla/mozilla2/mobile/android/base/BrowserApp.java:896: cannot find symbol
symbol  : variable Window
location: class org.mozilla.gecko.BrowserApp
            onCreatePanelMenu(Window.FEATURE_OPTIONS_PANEL, null);
                              ^

Comment 9

[Wesley Johnston (:wesj)]

Yeah. I'd been working on two different patches for this bug and that was in the second :)

https://hg.mozilla.org/integration/fx-team/rev/2f13d537fd49

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2f13d537fd49

Comment 11

[Flaviu Cos]

Verified as fixed in build Nightly 30.0a1 (2014-02-20);
Device: Google Nexus 7 (Android 4.4.2).