Closed Bug 962366 Opened 11 years ago Closed 11 years ago

Replace software home button with something that is not the browser icon

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 unaffected)

Status:
RESOLVED FIXED
Milestone:
1.3 Sprint 6 - 12/6
Tracking Flags:
Tracking Status
b2g-v1.3 --- fixed
b2g-v1.3T --- fixed
b2g-v1.4 --- unaffected

People

(Reporter: swilkes, Assigned: caseyyee.ca)

References

Details

(Whiteboard: visual-tracking, ux-tracking)

Attachments

(5 files, 3 obsolete files)

Software Home Key Icon @1 and @1.5 Res
51.28 KB, application/zip
praghunath
: approval-gaia-v1.3+
Details
Screen showing icon in context
182.07 KB, image/jpeg
Details
Patch for Gaia/master
46 bytes, text/x-github-pull-request
pivanov
: review+
Details | Review
Updated Assets
111.34 KB, application/zip
Details
big-962366-1.png
186.19 KB, image/png
pla
: ui-review+
Details 
We should replace the software home button with a white circle (what we have on the phones) or anything else that makes sense. Using the browser icon feels odd.
Casey and Peter, this is targeted for 1.3. As soon as you have an icon attached to this bug, please set the flag on the attachment to "approval-gaia-v1.3?". If you do not know whom to flag for approval, you may flag Preeti (praghunath). For a comment, leave something like "Needs approval; please approve for 1.3" or similar.
Target Milestone: --- → 1.3 Sprint 6 - 12/6
Casey, these icons should be rendered at 100% scale - ie. they don't need to be scaled.  Vertically centered on the black bar in which they appear.

I'm attaching a screenshot mockup to show what it looks like.
Attached image Screen showing icon in context (obsolete) — 

    
    

    
  
Comment on attachment 8366140 [details]
Software Home Key Icon @1 and @1.5 Res

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

        Attachment #8366140 -
        Flags: approval-gaia-v1.3?(praghunath)

    
  
Flags: needinfo?(praghunath)

    
    

    
  

      
      
      
      

        Attached image
          
        Screen showing icon in context (obsolete)
        — 
      

    


  

        Attachment #8366141 -
        Attachment is obsolete: true

    
    

    
  


  

        Attachment #8366159 -
        Attachment is obsolete: true

    
  

        Attachment #8366160 -
        Attachment description: Screen sowing icon in context → Screen showing icon in context

    
    

    
  
Comment on attachment 8366140 [details]
Software Home Key Icon @1 and @1.5 Res

approved for gaia 1.3

        Attachment #8366140 -
        Flags: approval-gaia-v1.3?(praghunath) → approval-gaia-v1.3+
Flags: needinfo?(praghunath)
Component: Gaia::Homescreen → Gaia::System

    
    

    
  

      
      
      
      

        Attached file
          
        Patch for Gaia/master
        — 
      

    


  

    
    

    
  

      
      
      
      

        Attached image
          
        big-962366.png (obsolete)
        — 
      

    


  
The circle is a larger than in the visuals and includes a :active press state where the outline turns to bright white.

        Attachment #8367817 -
        Flags: ui-review?(pla)

    
    

    
  
Comment on attachment 8367817 [details]
big-962366.png

Hi Casey,

The size feels fine.  I see a difference though, between your circle and the one I sent, which has a different thickness at the top of the ring (thinner) than at the bottom (thicker).  This was intentional to match the latest Hardware key icon design.  So if you could make that update, that would be great.

        Attachment #8367817 -
        Flags: ui-review?(pla) → ui-review-
Flags: needinfo?(kyee)

    
    

    
  

      
      
      
      

        Attached file
          
        Updated Assets
        — 
      

    


  
.PSDs included if you need to tweak.
No longer blocks: 965889

    
    

    
  

      
      
      
      

        Attached image
          
        big-962366-1.png
        — 
      

    


  

        Attachment #8367817 -
        Attachment is obsolete: true

        Attachment #8368240 -
        Flags: ui-review?(pla)
Flags: needinfo?(kyee)

    
    

    
  
Comment on attachment 8368240 [details]
big-962366-1.png

Looks great, thanks Casey!

        Attachment #8368240 -
        Flags: ui-review?(pla) → ui-review+

    
    

    
  
Comment on attachment 8367815 [details] [review]
Patch for Gaia/master

Thanks Peter!   Pavel, can you review this for me?

Thanks!

        Attachment #8367815 -
        Flags: review?(pivanov)

    
    

    
  
Comment on attachment 8367815 [details] [review]
Patch for Gaia/master

Nice one :)

        Attachment #8367815 -
        Flags: review?(pivanov) → review+

    
    

    
  
Merged to master
6e17d6a0d703c72ddd354134ee0f9e538a8f5aea
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

    
    

    
  
Sorry for intervening this rudely but I think we need a @1.5x version, because right now I'm having a square Firefox icon instead, on Peak. :)

    
    

    
  
Uplifted 6e17d6a0d703c72ddd354134ee0f9e538a8f5aea to:
v1.3: 6443275d5dc404ff047b8a7da8e77c5ff3a71b43

          status-b2g-v1.3:
          --- → fixed

    
  
Assignee: nobody → kyee

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: