962445 - Calendar events, that span 15 minutes (or less) are not displayed correctly in Week view.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Tony Chung [:tchung]]

+++ This bug was initially created as a clone of Bug #830180 +++

As discussed in Productivity Triage, I am filing a new bug off of 830180.  i am told that bug was inadvertently fixed by another bug for day/month view.  This bug is to track the same problem, but with week view.  

Assigned to Gareth for investigation.

Comment 1

[Harly Hsu[:harly]]

I am proposing that adding a minimum hight 15 minutes for week event, and any event time below 15 minutes will be displayed the same hight. Furthermore, system will display event title of overlapping week events until there are no space to display any single text.

Comment 2

[Miller Medeiros [:millermedeiros]]

taking this since I already implemented something similar on the visual refresh (see: https://bug951071.bugzilla.mozilla.org/attachment.cgi?id=8383326).

Comment 3

[Miller Medeiros [:millermedeiros]]

Attachment: 15min_week.png

Hi Harly, the simplest solution is to replicate what the day view currently does (set a minimum height for the event). It looks like minimum height to display the text without cropping is 1.8rem (18min).

If we have 2 consecutive events that lasts less than 18min they will overlap (like they currently do in the day view), but I think this is an improvement from current behavior and I consider 2 consecutive events <18min to be an edge-case. - see events at 7pm (both have 10min).

During visual refresh we will change the behavior (we will hide the copy if too small). So I don't think we need an integration test for this (it's a 1 line CSS change if we do it like the screenshot).

Changing the overlap calculation logic is not trivial and will probably introduce work that we will need to revert after visual refresh. - if you want to show events side-by-side instead of overlapping if <18min - It's an option but will probably take a couple extra days.

Let me know what you think.

Comment 4

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17211

discussed with Gareth and we decided to go forward with the min-height change. later we can fill another bug to avoid the overlaps (since it's not a simple change and might introduce regressions). This matches behavior of screenshot (previous attachment).

Comment 5

[Gareth Aye [:gaye] (back from PTO)]

https://github.com/mozilla-b2g/gaia/commit/158a4ec9248c7ee10bf5466a5803bfc926cec0e7

Comment 6

[Edward Chen[:edchen]]

[Environment]
aia      8f802237927c7d5e024fb7dca054dd5efef6b2e6
Gecko     https://hg.mozilla.org/mozilla-central/rev/907cacf958de
BuildID   20140316160201
Version   30.0a1
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013


[Result]
PASS
Request changed, I mark it to "VERIFIED"