96245 - Including <windowsx.h> even for non windows platforms

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[timeless]

spun off from bug 73436

please wrap or remove these 2 windowsisms

Comment 1

[av (gone)]

Thanks, timeless!
Here is the fix
Index: logger.cpp
===================================================================
RCS file: /cvsroot/mozilla/modules/plugin/tools/spy/common/logger.cpp,v
retrieving revision 1.1
diff -u -r1.1 logger.cpp
--- logger.cpp  2001/03/25 23:38:24     1.1
+++ logger.cpp  2001/08/21 21:15:16
@@ -22,7 +22,6 @@
  */

 #include "xp.h"
-#include <windowsx.h>

 #include "resource.h"
 #include "logger.h"

Comment 2

[av (gone)]

Ah, there is one more. Sorry, the patch will follow.

Comment 3

[av (gone)]

Attachment: second try

Comment 4

[timeless]

I'm not sure this works for BeOS and other unix like's, actually i'm sure it'll 
break something.

iirc, OS2 and Windows should be grouped together
BeOS needs to be grouped w/ Unix.

I think i'd do this:

+#ifdef XP_MAC
+  #define DIR_SEPARATOR ":"
+#else
+  #if defined(XP_WINDOWS) || defined (XP_OS2)
+    #define DIR_SEPARATOR "\\"
+  #else
+    /* Unix, BeOS, ... */
+    #define DIR_SEPARATOR "/"
+  #endif
+#endif

but r=timeless for the code attempt 1, and we get some people to think about 
problem 2 [i'm just waking up and have thousands of bugmails before i sleep].

Comment 5

[av (gone)]

I'll include your correction as a starting point. If this is going to break
something it will not happen soon. Non-Windows platforms have not even started
to be addressed in this project (and I am not aware of any concrete plans in
this direction), and the project itself is not part of the regular build. Which
is probably a bad thing.

Comment 6

[timeless]

it's XP_WIN. clearly i wasn't awake

Comment 7

[av (gone)]

Checked in.

Comment 8

[timeless]

vrfy fixed