962514 - Test failure 'client process shutdown unsuccessful' in testAddons/testInstallAddonWithEULA.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Andrei Eftimie]

This fails to complete the testrun.

We should skip the test ASAP (also check if other tests are affected and skip them as well) so we can have a complete remote testrun.

I can reproduce this locally.
Both Nightly and Aurora are affected.

We might need to use the new mozrunner version. This needs to be confirmed.

Visually we are unable to handle the Install Extension Dialog. That remains open before the failure.

I'll have a skip patch ready asap.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This problem depends on multiple bugs. The failure you can see here is bug 794020. But the underlying problem is that we fetch AMO meta data and that AMO is responding too slow. So we quit the application with the modal installation dialog open. The pref as changed on bug 960976 will fix that.

Comment 2

[Andrei Eftimie]

Attachment: skip.patch

testrun_remote now finishes:
http://mozmill-crowd.blargon7.com/#/remote/report/94e33fe3d7ec0be6dbbfa0a702f0fa5d

Comment 3

[Andrei Eftimie]

Applies cleanly on Aurora:
http://mozmill-crowd.blargon7.com/#/remote/report/94e33fe3d7ec0be6dbbfa0a702f13e4f

Comment 4

[Andrei Eftimie]

Beta is also affected. Patch applies cleanly as well.

Comment 5

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8363584 [details] [diff] [review]
skip.patch

Review of attachment 8363584 [details] [diff] [review]:
-----------------------------------------------------------------

Disabled:
http://hg.mozilla.org/qa/mozmill-tests/rev/c81d4df0c990 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/c378731999da (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/1d04d7137a7b (beta)

Comment 6

[Andrei Eftimie]

This is actually a change in AMO, we expect a page to accept EULA terms, which doesn't exist anymore.

Comment 7

[Andrei Eftimie]

Regressor found: bug 743829

Which got merged recently:
https://github.com/mozilla/zamboni/commit/5611c342f588e5eed42c25ac3ba92c1ab09a532b

With this information I don't think this test is viable anymore.
There are no more different steps to install an addon which has EULA vs an addon that doesn't have it.

Comment 8

[mario garbi]

Attachment: minimized.js

Here is a minimized test for this issue. The problem was that we have a modal window that we do not handle and mozmill cannot properly close the Firefox client when the test is done (either successful or failed).

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thanks Mario. That's exactly what I was thinking of in comment 1. So not sure why bug 960495 has been removed from the dependency list by Andrei. So putting it back given that we need the fix for bug 794020 in Mozmill 2.0.4.

Comment 10

[Andrei Eftimie]

I took it out since we are going to remove this test.

Mario, as Henrik also said on IRC, please check testGreenLarry with mozmill (on the master branch) and see if the failure cause is the same as here.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Please take the appropriate steps to get this test removed then. If green larry fails please handle that on a different bug. Thanks.

Comment 12

[mario garbi]

Green larry fails too but seems to be an entirely different issue. With the latest mozmill from github (master branch) we seem to get stuck loading the remote webpage until we hit the timeout after which mozmill is unable to close the client for whatever reasons. There are no modal windows involved here.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to mario garbi from comment #12)
> Green larry fails too but seems to be an entirely different issue. With the
> latest mozmill from github (master branch) we seem to get stuck loading the
> remote webpage until we hit the timeout after which mozmill is unable to
> close the client for whatever reasons. There are no modal windows involved
> here.

That's helpful information but you have read my last comment, or? This feedback is inappropriate here on this bug.

Comment 14

[mario garbi]

Attachment: testRemove.patch

Adding a patch that removes testInstallAddonWithEULA.js from the repository since we no longer have need of it.

Comment 15

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8367190 [details] [diff] [review]
testRemove.patch

Review of attachment 8367190 [details] [diff] [review]:
-----------------------------------------------------------------

Removed:
http://hg.mozilla.org/qa/mozmill-tests/rev/eadabd2001d4 (default)

Please check what other branches are affected and flag them.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Given that it was a change on AMO all branches should be affected where this test exists.

Comment 17

[Andrei Eftimie]

Removed:
http://hg.mozilla.org/qa/mozmill-tests/rev/2bab8ba6cfbe (mozilla-aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/c8d8591a0a39 (mozilla-beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/ccb876363940 (mozilla-release)

We've already done the merge from Beta > Release so both branches are identical ATM.