962566 - [Contacts] When viewing contact details from the Messages app (via Activity) the dialer icon does not call and goes back to the thread

Status: RESOLVED DUPLICATE of bug 957338

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Maria Angeles Oteo (:oteo)]

Description:
Viewing contact info from the header (contact name) in the message tread will open a contact details page where the dialer icon does not call (goes back to the thread)
Repro Steps:

1) Have existing contact on device
2) Have some messages to or from that contact
3) Open Messages app 
4) Open existing thread
5) Tap on the contact name (header)
6) Select to View contact
7) Tap on dialer icon to call to the contact

Actual:
go back to the messaging thread

Expected:
Dialer is opened with the contact number entered.

buri
v1.3
B-42
Gecko-11478a2
Gaia-ee25b0e

Comment 1

[Preeti Raghunath(:Preeti)]

David,

Please review for contacts.

Made 1.3+

Comment 2

[Nikolai Khristoforov]

The regression window for this bug is 10/23 to 10/24. I noticed that the functionality changed between the two builds when tapping on the contact header in the SMS thread. On 10/23, the user is taken straight to the Dialer whereas the 10/24 build has a menu appear with a "Call" option and a "View contact" option.

Last Working Build:
Device: Buri 1.3 MOZ
BuildID: 20131023040203
Gaia: 6d23c2f9153d0e1d17679cb9c317e75a0ee9a490
Gecko: 21d97baadc05
Version: 27.0a1
Firmware Version: V1.2-device.cfg

First Broken Build:
Device: Buri 1.3 MOZ
BuildID: 20131024154023
Gaia: 2feebdb1a2583928f32407d76d798f8654621e2b
Gecko: 19fd3388c372
Version: 27.0a1
Firmware Version: V1.2-device.cfg

Comment 3

[Maria Angeles Oteo (:oteo)]

> functionality changed between the two builds when tapping on the contact
> header in the SMS thread. On 10/23, the user is taken straight to the Dialer
> whereas the 10/24 build has a menu appear with a "Call" option and a "View
> contact" option.

you are right Nikolai, there was a change in this functionality, it is explained by Ayman in Bug 957338 (I included the dependency with that bug) 

Both bugs, bug 962566 and bug 957338 raised when "View Contact"option was included when tapping on the contact header in the thread. Both of them seem to be caused by the limitation of launching some operations (mainly opening other web activities) if contacts is already being invoked as a web activity.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Marking as duplicate of bug 957338, since the error is the same.

We were not allowing to execute the call action when we are in an activity. Since now we allow to view a contact detail from an activity, we are going to enable the actions like send sms or call.

So the code is the same than the bug 957338 patch.

Also removing 'regression' keyword, since this is not a regression, we didn't have this functionality prior version 1.3.

Cheers.

Comment 5

[David Scravaglieri [:scravag]]

clear n?