963504 - [Contacts] Add unit tests to activity handling

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Francisco Jordano [:arcturus] [:francisco]]

In Bug 957338 we have been dealing with a problem added with a new web activity 'open'.

Right now we don't have unit tests for all the sets of activities that contacts offer.

We should create a complete suite of tests for all of them, and try them in combination with other activities as well.

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to pr 20997

Adding several ammount of tests to contacts.js specially the cases where activities were involved.

Created a lot of new test that we didn't have in such an important class as the Contacts one.

Moved from 23% coverage to 43%, still not enough, but getting there.

Comment 2

[Jose Manuel Cantera]

Comment on attachment 8446208 [details] [review]
Pointer to pr 20997

thanks Francisco. I like the work. I have left a few comments in GH for your consideration. 

best

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Applying modifications before merging.

Thanks!

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/0bc5b5349cf8b2eb921436dd88742b9891aefce4

Comment 5

[Sue]

Could you provide the detailed reproduce steps or video for me to verify this bug. Thanks!

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Hi, this bug is for adding more unit tests, the way of verifying this is passing the unit tests, that right now are passing without problem.