Closed
Bug 963504
Opened 11 years ago
Closed 10 years ago
[Contacts] Add unit tests to activity handling
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(b2g-v2.1 verified)
VERIFIED
FIXED
2.0 S5 (4july)
Tracking | Status | |
---|---|---|
b2g-v2.1 | --- | verified |
People
(Reporter: arcturus, Assigned: arcturus)
References
Details
(Whiteboard: [p=2])
Attachments
(1 file)
In Bug 957338 we have been dealing with a problem added with a new web activity 'open'. Right now we don't have unit tests for all the sets of activities that contacts offer. We should create a complete suite of tests for all of them, and try them in combination with other activities as well.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → francisco.jordano
Assignee | ||
Updated•10 years ago
|
Target Milestone: --- → 2.0 S5 (4july)
Assignee | ||
Updated•10 years ago
|
Whiteboard: [p=2]
Assignee | ||
Comment 1•10 years ago
|
||
Adding several ammount of tests to contacts.js specially the cases where activities were involved. Created a lot of new test that we didn't have in such an important class as the Contacts one. Moved from 23% coverage to 43%, still not enough, but getting there.
Attachment #8446208 -
Flags: review?(jmcf)
Comment 2•10 years ago
|
||
Comment on attachment 8446208 [details] [review] Pointer to pr 20997 thanks Francisco. I like the work. I have left a few comments in GH for your consideration. best
Attachment #8446208 -
Flags: review?(jmcf) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Landed: https://github.com/mozilla-b2g/gaia/commit/0bc5b5349cf8b2eb921436dd88742b9891aefce4
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
status-b2g-v2.1:
--- → fixed
Could you provide the detailed reproduce steps or video for me to verify this bug. Thanks!
Flags: needinfo?(francisco)
Assignee | ||
Comment 6•10 years ago
|
||
Hi, this bug is for adding more unit tests, the way of verifying this is passing the unit tests, that right now are passing without problem.
Flags: needinfo?(francisco)
You need to log in
before you can comment on or make changes to this bug.
Description
•