962721 - Chrome draws in content on forecast.io

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

STR:
- Load forcast.io/lines
- Enter a new location
- Hit enter to switch to that location

A simple bisection suggests http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cf2d1bd796ea&tochange=711f08b0aa

The most suspect are benoit's opengl changes in bug 956401, bug 960904, and bug 956141

Comment 3

[Markus Stange [:mstange]]

Attachment: testcase

Comment 4

[Jeff Muizelaar [:jrmuizel]]

This seems to have been caused by
https://hg.mozilla.org/mozilla-central/rev/b75d69931d4a

Comment 5

[Benjamin Kerensa [:bkerensa]]

Benoit, Can you have a look at this?

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

Jeff and I spent time on this yesterday, he is off today, but I suppose that we'll be back to it next week.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Looks like this is caused by CopyTexImage2D

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Attachment: Handle the flip for CopyTexImage2D

Looks like this was forgotten from the conversion.

Comment 9

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 8367662 [details] [diff] [review]
Handle the flip for CopyTexImage2D

Review of attachment 8367662 [details] [diff] [review]:
-----------------------------------------------------------------

Ouch, sorry for all the effort that this omission incurred, and congrats for fixing it. Have you checked that all other calls of copyTex[Sub]Image2D have received the FlipY treatment?

Comment 12

[Jeff Muizelaar [:jrmuizel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/074e87ffb410

Comment 13

[Benjamin Kerensa [:bkerensa]]

Do you still think needs tracking since a patch has been landed that likely addresses this bug?

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/074e87ffb410

Comment 15

[Jeff Muizelaar [:jrmuizel]]

(In reply to Benjamin Kerensa [:bkerensa] from comment #13)
> Do you still think needs tracking since a patch has been landed that likely
> addresses this bug?

No.

Comment 16

[Benjamin Kerensa [:bkerensa]]

Based on Comment 15 will not be tracking this.