Closed Bug 962931 Opened 10 years ago Closed 10 years ago

Intermittent TEST-UNEXPECTED-FAIL | browser_webconsole_split.js | This test exceeded the timeout threshold.

Categories

(DevTools :: Console, defect)

Product:
DevTools
Component:
Console
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox29 fixed, firefox30 fixed, firefox31 fixed, firefox-esr24 unaffected)

Status:
RESOLVED FIXED
Milestone:
Firefox 31
Tracking Flags:
Tracking Status
firefox29 --- fixed
firefox30 --- fixed
firefox31 --- fixed
firefox-esr24 --- unaffected

People

(Reporter: KWierso, Assigned: bgrins)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

webconsole-split.patch
1.32 KB, patch
msucan
: review+
Details | Diff | Splinter Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=33422266&tree=Mozilla-Inbound
slave: talos-r3-fed64-069



15:03:51     INFO -  [Parent 2877] WARNING: NS_ENSURE_TRUE(window) failed: file ../../../dom/base/nsLocation.cpp, line 44
15:03:51     INFO -  [Parent 2877] WARNING: NS_ENSURE_TRUE(enabled) failed: file ../../../dom/base/Navigator.cpp, line 1892
15:03:51     INFO -  [Parent 2877] WARNING: NS_ENSURE_TRUE(enabled) failed: file ../../../dom/base/Navigator.cpp, line 1711
15:03:51     INFO -  [Parent 2877] WARNING: Please do not use mouseenter/leave events in chrome. They are slower than mouseover/out!: '!nsContentUtils::IsChromeDoc(d)', file ../../../dom/events/nsEventListenerManager.cpp, line 350
15:03:51     INFO -  [Parent 2877] WARNING: Subdocument container has no frame: file ../../../layout/base/nsDocumentViewer.cpp, line 2412
15:03:51     INFO -  ++DOMWINDOW == 443 (0xfbd1088) [pid = 2877] [serial = 17342] [outer = 0x1726ea08]
15:03:51     INFO -  [Parent 2877] WARNING: No inner window available!: file ../../../dom/base/nsGlobalWindow.cpp, line 9387
15:03:51     INFO -  console.error:
15:03:51     INFO -    _createPropertyViews cancelled
15:03:51     INFO -  JavaScript strict warning: chrome://browser/content/devtools/layoutview/view.js, line 270: reference to undefined property this.layoutview
15:03:51     INFO -  JavaScript error: chrome://browser/content/devtools/layoutview/view.js, line 270: this.layoutview is undefined
15:03:51     INFO -  [Parent 2877] WARNING: NS_ENSURE_TRUE(mMutable) failed: file ../../../../netwerk/base/src/nsSimpleURI.cpp, line 265
15:03:51  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_split.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort.
15:03:51     INFO -  TEST-INFO | MEMORY STAT vsize after test: 3052576768
15:03:51     INFO -  TEST-INFO | MEMORY STAT residentFast after test: 1041477632
15:03:51     INFO -  INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_split.js | finished in 31128ms
15:03:51     INFO -  TEST-INFO | checking window state
15:03:51     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_split.js | must wait for focus
Brian, do you think we can split the test in two tests? Test machines seem to be ever slower and now we've started to get a sizable number of intermittent test timeouts with this test.
Flags: needinfo?(bgrinstead)
(In reply to Mihai Sucan [:msucan] from comment #11)
> Brian, do you think we can split the test in two tests? Test machines seem
> to be ever slower and now we've started to get a sizable number of
> intermittent test timeouts with this test.

It runs the same set of tests for the bottom host, sidebar host, and window host.  So it seems like a candidate to split one tests for each host.  Unfortunately the meat of the tests (checkWebconsolePanelOpened, checkAllTools, getCurrentUIState, checkToolboxUI) would need to be copied and pasted to all three new tests unless if there was a way to share this functionality.

Alternatively, we could limit the scope of the test to run on only one or two other panels instead of 5, since it isn't too likely to break on just one of them: https://mxr.mozilla.org/mozilla-central/source/browser/devtools/webconsole/test/browser_webconsole_split.js#51.  There is a small risk with this - if one of the untested panels overwrote the esc key the test wouldn't catch it.
Flags: needinfo?(bgrinstead)
Either way is fine for me. Just test one toolbox host or split the test into three tests.
For inspiration on sharing code between tests you could look at the various helper modules we have, like gcli's helper.js which gets loaded like this:

http://dxr.mozilla.org/mozilla-central/source/browser/devtools/commandline/test/head.js#10

I think there is also a standard path for loading test-specific JSMs, but I can't find the documentation about it right now.
What do you think about doing a requestLongerTimeout instead of splitting it into pieces?  As https://bugzilla.mozilla.org/show_bug.cgi?id=982359#c11 indicates, the test is only failing because the VM is too slow to run it.  Requesting more time would be the easiest way to make the problem go away.
needinfo? for Comment 21
Flags: needinfo?(mihai.sucan)
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Cancelling needinfo and just applying patch with the requestLongerTimeout.  Mihai, let me know if you think it would be better to split it up.
Attachment #8395676 - Flags: review?(mihai.sucan)
Flags: needinfo?(mihai.sucan)
Comment on attachment 8395676 [details] [diff] [review]
webconsole-split.patch

A longer timeout works for me. Thanks!
Attachment #8395676 - Flags: review?(mihai.sucan) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/3c49b1601653
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/3c49b1601653
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: