963023 - libevent: Check does arch have the epoll_create and __NR_epoll_wait syscalls.

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Marcin Juszkiewicz]

Attachment: Patch with backport from upstream

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140122030521

Steps to reproduce:

Some architectures (like AArch64) does not support deprecated syscalls. This change makes libevent check and use proper ones.

Merged upstream: https://github.com/nmathewson/Libevent/commit/dfe1e526f5bb9db3c0b28d848170f35521ebd314

Comment 1

[Nathan Froyd [:froydnj]]

Comment on attachment 8364269 [details] [diff] [review]
Patch with backport from upstream

Review of attachment 8364269 [details] [diff] [review]:
-----------------------------------------------------------------

I don't have a problem with backporting the patch, but I'm not sure I completely understand how we patch libevent.  I see patches in ipc/chromium/src/third_party/libevent/, but I also see patches in ipc/chromium/src/third_party/.  Josh, what's our policy for patches for libevent?

To be clear: please don't flag this for checkin-needed until we sort out whether the patch as-is is sufficient or whether you also need a separate .patch file to be added somewhere.

Comment 2

[Josh Aas]

Add another step in the README.mozilla file in the libevent directory. Put the patch in the libevent dir along with the other patches discussed in README.mozilla, with a nice name. Commit the edit to README.mozilla, the patch file itself, and the application of the patch all at the same time.

Thanks for checking.

Comment 3

[Marcin Juszkiewicz]

Attachment: libevent.patch

Comment 4

[Josh Aas]

Comment on attachment 8367844 [details] [diff] [review]
libevent.patch

Review of attachment 8367844 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good except the patch is missing the patch itself as an added file. Perhaps you just forgot "hg add".

Comment 5

[Marcin Juszkiewicz]

Attachment: libevent.patch

added patch itself into patch

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4e9b713f435a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4e9b713f435a