Closed
Bug 963028
Opened 11 years ago
Closed 11 years ago
AArch64 support for jemalloc
Categories
(Core :: Memory Allocator, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: marcin, Unassigned)
References
Details
Attachments
(1 file, 2 obsolete files)
|
1.74 KB,
patch
|
marcin
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140122030521
|
Reporter | |
Updated•11 years ago
|
Attachment #8364276 -
Flags: review?(nfroyd)
|
||
Updated•11 years ago
|
Attachment #8364276 -
Flags: review?(nfroyd) → review+
|
|
Reporter | |
Comment 1•11 years ago
|
||
I hope that I got this hgpatch right.
Attachment #8364276 -
Attachment is obsolete: true
Attachment #8364360 -
Flags: review+
|
|
||
Comment 2•11 years ago
|
||
The patch looks great, but you want to change the title to be:
Bug 963028 - jemalloc: support AArch64 architecture;r=froydnj
rather than just some generic "reviewers". I'm guessing you converted this from git; ideally your conversion tool will have some way of setting the reviewers on the exported patch.
Once you've done that, you should be able to set the checkin-needed keyword on the bug, and somebody will come along within a day or so and commit the patch to mozilla-inbound.
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
|
Reporter | |
Comment 3•11 years ago
|
||
Attachment #8364360 -
Attachment is obsolete: true
Attachment #8364375 -
Flags: review+
|
|
Reporter | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
Page size is really 64k on aarch64?
|
||
Comment 5•11 years ago
|
||
Keywords: checkin-needed
|
|
Reporter | |
Comment 6•11 years ago
|
||
CONFIG_ARM64_64K_PAGES:
This feature enables 64KB pages support (4KB by default) allowing only two levels of page tables and faster TLB look-up. AArch32 emulation is not available when this feature is enabled.
|
|
||
Comment 7•11 years ago
|
||
BTW, you'll want this in upstream jemalloc, too.
|
||
Comment 8•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
|
|
Reporter | |
Comment 9•11 years ago
|
||
LG_QUANTUM part is in jemalloc for quite long time:
commit daf6d0446ce64fb563b7d96fda077e6406c602be
Author: Riku Voipio <riku.voipio@linaro.org>
Date: Mon Mar 18 16:40:20 2013 +0200
Add aarch64 LG_QUANTUM size definition
Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
pagesize_2pow part looks to be mozilla code only
You need to log in
before you can comment on or make changes to this bug.
Description
•