Closed Bug 963028 Opened 6 years ago Closed 6 years ago

AArch64 support for jemalloc

Categories

(Core :: Memory Allocator, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: marcin, Unassigned)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch aarch64-memory.patch (obsolete) — Splinter Review
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140122030521
Blocks: 962534
Attachment #8364276 - Flags: review?(nfroyd)
Attachment #8364276 - Flags: review?(nfroyd) → review+
Attached patch jemalloc.patch (obsolete) — Splinter Review
I hope that I got this hgpatch right.
Attachment #8364276 - Attachment is obsolete: true
Attachment #8364360 - Flags: review+
The patch looks great, but you want to change the title to be:

Bug 963028 - jemalloc: support AArch64 architecture;r=froydnj

rather than just some generic "reviewers".  I'm guessing you converted this from git; ideally your conversion tool will have some way of setting the reviewers on the exported patch.

Once you've done that, you should be able to set the checkin-needed keyword on the bug, and somebody will come along within a day or so and commit the patch to mozilla-inbound.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attachment #8364360 - Attachment is obsolete: true
Attachment #8364375 - Flags: review+
Keywords: checkin-needed
Page size is really 64k on aarch64?
CONFIG_ARM64_64K_PAGES:

This feature enables 64KB pages support (4KB by default) allowing only two levels of page tables and faster TLB look-up. AArch32 emulation is not available when this feature is enabled.
BTW, you'll want this in upstream jemalloc, too.
https://hg.mozilla.org/mozilla-central/rev/feaf8bd56a82
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
LG_QUANTUM part is in jemalloc for quite long time:

commit daf6d0446ce64fb563b7d96fda077e6406c602be
Author: Riku Voipio <riku.voipio@linaro.org>
Date:   Mon Mar 18 16:40:20 2013 +0200

    Add aarch64 LG_QUANTUM size definition
    
    Signed-off-by: Riku Voipio <riku.voipio@linaro.org>

pagesize_2pow part looks to be mozilla code only
Blocks: 1091515
You need to log in before you can comment on or make changes to this bug.